Review main Merged

73180[TASK] Use new backend templating in various controllers

Christian Kuhn CR +2 V +2 Nightmare +2905 −2943 updated 02/04/22, 21:08

Commit message

This adapts a series of controllers and view
templates to use the ModuleTemplate as view.

The strategy is similar: $moduleTemplate is renamed
to $view, the former "body" view based on
BackendTemplateView is gone. Templates use the
backend Module.html as layout.

Some controllers are left out from this
patch since they need bigger refactoring.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 99

Show 79 more files

Review log 4881

Show 2956 earlier messages
  1. Christian Kuhn uploaded patch set 1 01/27/22, 14:51

  2. Christian Kuhn updated the commit message in patch set 2 01/27/22, 14:52

  3. Christian Kuhn uploaded patch set 3 01/27/22, 14:53

  4. core-ci voted on patch set 1 V -1 01/27/22, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22569

  5. core-ci voted on patch set 2 V -1 01/27/22, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22570

  6. core-ci voted on patch set 3 V -1 01/27/22, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22571

  7. Christian Kuhn uploaded patch set 4 01/27/22, 15:22

  8. core-ci voted on patch set 4 V -1 01/27/22, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22572

  9. Christian Kuhn uploaded patch set 5 01/27/22, 15:44

  10. core-ci voted on patch set 5 V -1 01/27/22, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22573

  11. Christian Kuhn uploaded patch set 6 01/27/22, 17:21

  12. core-ci voted on patch set 6 V -1 01/27/22, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22581

  13. Christian Kuhn uploaded patch set 7 01/27/22, 17:38

  14. Christian Kuhn commented on patch set 7 01/27/22, 17:48

    ModuleTemplateFactory.php:93

    we don't need this.
  15. core-ci voted on patch set 7 V -1 01/27/22, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22584

  16. Christian Kuhn uploaded patch set 8 01/31/22, 11:49

  17. Christian Kuhn commented on patch set 8 01/31/22, 11:49

    rebased.
  18. core-ci voted on patch set 8 V -1 01/31/22, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22793

  19. Christian Kuhn uploaded patch set 9 01/31/22, 14:06

  20. Christian Kuhn commented on patch set 9 01/31/22, 14:09

    ModuleTemplateFactory.php:93 Reply

    Done
  21. core-ci voted on patch set 9 V -1 01/31/22, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22810

  22. Christian Kuhn uploaded patch set 10 01/31/22, 15:03

  23. Christian Kuhn uploaded patch set 11 01/31/22, 15:06

  24. core-ci voted on patch set 10 V -1 01/31/22, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22812

  25. Christian Kuhn uploaded patch set 12 01/31/22, 15:07

  26. core-ci voted on patch set 11 V -1 01/31/22, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22813

  27. core-ci voted on patch set 12 V -1 01/31/22, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22814

  28. Christian Kuhn uploaded patch set 13 01/31/22, 15:22

  29. core-ci voted on patch set 13 V +1 01/31/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22815

  30. Christian Kuhn uploaded patch set 14 01/31/22, 17:28

  31. core-ci voted on patch set 14 V -1 01/31/22, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22819

  32. Christian Kuhn uploaded patch set 15 01/31/22, 18:28

  33. core-ci voted on patch set 15 V -1 01/31/22, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22820

  34. Christian Kuhn uploaded patch set 16 01/31/22, 21:40

  35. core-ci voted on patch set 16 V -1 01/31/22, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22830

  36. Christian Kuhn uploaded patch set 17 01/31/22, 22:02

  37. core-ci voted on patch set 17 V +1 01/31/22, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22831

  38. Christian Kuhn uploaded patch set 18 02/01/22, 01:03

  39. core-ci voted on patch set 18 V +1 02/01/22, 01:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22848

  40. Christian Kuhn uploaded patch set 19 02/02/22, 11:22

  41. core-ci voted on patch set 19 V +1 02/02/22, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22900

  42. Christian Kuhn uploaded patch set 20 02/02/22, 12:21

  43. core-ci voted on patch set 20 V -1 02/02/22, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22903

  44. Christian Kuhn uploaded patch set 21 02/03/22, 16:49

  45. core-ci voted on patch set 21 V -1 02/03/22, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22960

  46. Christian Kuhn uploaded patch set 22 02/03/22, 17:01

  47. core-ci voted on patch set 22 V -1 02/03/22, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22961

  48. Christian Kuhn uploaded patch set 23 02/03/22, 17:14

  49. core-ci voted on patch set 23 V +1 02/03/22, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22962

  50. Christian Kuhn uploaded patch set 24 02/03/22, 19:06

  51. core-ci voted on patch set 24 V +1 02/03/22, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22970

  52. Christian Kuhn uploaded patch set 25 02/03/22, 20:35

  53. core-ci voted on patch set 25 V +1 02/03/22, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22972

  54. Christian Kuhn uploaded patch set 26 02/03/22, 21:00

  55. core-ci voted on patch set 26 V -1 02/03/22, 21:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22975

  56. core-ci commented on patch set 26 02/03/22, 21:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22975

  1. Christian Kuhn uploaded patch set 27 02/04/22, 11:37

  2. core-ci voted on patch set 27 V -1 02/04/22, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22993

  3. Christian Kuhn uploaded patch set 28 02/04/22, 12:00

  4. Christian Kuhn uploaded patch set 29 02/04/22, 12:11

  5. core-ci voted on patch set 28 V -1 02/04/22, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22995

  6. core-ci voted on patch set 29 V -1 02/04/22, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22996

  7. Christian Kuhn uploaded patch set 30 02/04/22, 12:30

  8. Oli Bartsch commented on patch set 30 02/04/22, 12:36

    FileListController.php:179

    What do you mean with this comment? Those modules usually do not relate to each other, e.g. ContextMenu and MultiRecordSelection. How should they be merged?
  9. core-ci voted on patch set 30 V +1 02/04/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22997

  10. Christian Kuhn uploaded patch set 31 02/04/22, 12:42

  11. Christian Kuhn commented on patch set 30 02/04/22, 12:42

    FileListController.php:179 Reply

    unsure. i only moved this comment around. i'll remove it.
  12. core-ci voted on patch set 31 V +1 02/04/22, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22998

  13. Benjamin Franzke commented on patch set 31 02/04/22, 14:37

    PermissionController.php:126

    hm.. there is nothing that transforms such excpetion back to a 400 error, and it will cause an internal-server error (which this isn't) and corresponding logs that are misleading for site owners,. But as responseFactory is injected anyway, return $this->responseFactory->createResponse(400); would be fine here. (fine for me to drop the 'Action not allowed' string)
  14. Christian Kuhn commented on patch set 31 02/04/22, 14:53

    PermissionController.php:126 Reply

    I changed that by intention: There is no 'normal' way to call reach the module with some different action, backend users shouldn't be able to trigger this without manipulation of something. I thus think that an exception is appropriate here.
  15. Benni Mack commented on patch set 31 02/04/22, 15:39

    PermissionController.php:126 Reply

    I'd actually just return indexAction() at all times and get rid of the last if() condition.
  16. Stefan Bürk commented on patch set 31 02/04/22, 15:55

    PermissionController.php:126 Reply

    I'm unsure here. I'm getting lolli's point, and feels right in the first moment. However from a "user" perspective and the point, that extensions developer may lookup core code ("how does this work in core?") for implementing own backend modules I'm flipping between suggestion from Benni and Benjamin which have both their points over the \Runtime exception here. I think we should consider what we may add here as a "example" how such cases should be handled by core and extensions. With that in mind I would tend either to Benjamins suggestions OR using suggestion from Benni with additional comment like "Unmatched action return default index index instead of returning an error/page not availabe response" or something like that. If using Benni's solution I would suggest to add an error logging here so this "attemp to fake" or "something went wrong" is at least logged. From extension side the error response may be the better solution, to get better information during development, on the other hand I think default action fallback is saner here from a usability standpoint here.
  17. Christian Kuhn commented on patch set 31 02/04/22, 16:06

    PermissionController.php:126 Reply

    i think we have similar code at other places that tend to throw exceptions, too. but we could simplify the discussion at this point by just going the response-400 way as it has been before. that change was scope-creep anyways.
  18. Christian Kuhn commented on patch set 31 02/04/22, 17:01

    PermissionController.php:126 Reply

    changed my mind again, i'll go the benni way: 'index' is fallback.
  19. Christian Kuhn uploaded patch set 32 02/04/22, 17:01

  20. core-ci voted on patch set 32 V +1 02/04/22, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23010

  21. Benjamin Franzke commented on patch set 32 CR +1 02/04/22, 20:43

    Index.html:20

    gerrit diff really looks awkward in here, but there are zero changed in here besides indentation. all fine, just wanted to mention.
  22. Benjamin Franzke voted on patch set 32 V +1 02/04/22, 20:49

  23. Stefan Bürk voted on patch set 32 V +1 CR +1 02/04/22, 21:00

  24. Christian Kuhn voted on patch set 32 V +2 CR +2 02/04/22, 21:07

  25. Christian Kuhn merged patch set 33 02/04/22, 21:08