Review main Merged

73183[BUGFIX] Correctly calculate bit-masks in JavaScriptModuleInstruction

Oliver Hader CR +2 V +2 Easy +49 −1 updated 01/28/22, 13:12

Commit message

Method JavaScriptModuleInstruction::addFlags used plain arithmetic
calculation on bit-masks. In case corresponding flags were just
given once, that would not have lead to problems. However, enabling
the same bits multiple times would have lead to side-effects
like disabling the added bit or enabling others.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Oliver Hader uploaded patch set 1 01/27/22, 17:41

  2. Benjamin Franzke voted on patch set 1 CR +1 01/27/22, 17:44

  3. Benjamin Franzke voted on patch set 1 V +1 01/27/22, 17:52

  4. core-ci voted on patch set 1 V +1 01/27/22, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22585

  5. Benjamin Franzke updated the commit message in patch set 2 01/27/22, 19:24

  6. core-ci voted on patch set 2 V +1 01/27/22, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22593

  7. Nikita Hovratov voted on patch set 2 V +1 CR +1 01/28/22, 13:12

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/28/22, 13:12

  9. Benjamin Franzke merged patch set 3 01/28/22, 13:12