Review main Merged

73184[BUGFIX] Ensure PageRenderer utility scripts are cache invalidatable

Benjamin Franzke CR +2 V +2 Easy +9 −7 updated 02/14/22, 10:01

Commit message

Cache busting parameters need to be added to any JavaScript
resource to force browsers to re-download these files after updates.

JavaScriptItemHandler.js changed between TYPO3 v11.5.3 and v11.5.4
and therefore needs to be updated by browsers. The same fix is applied
to requirejs-loader.js as this file changed between v11 and v12.

A micro optimization is made by avoiding that JavaScriptRenderer
is created twice during PageRenderer creation.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1014

  1. Benjamin Franzke uploaded patch set 1 01/27/22, 18:58

  2. Benjamin Franzke uploaded patch set 2 01/27/22, 19:02

  3. Benjamin Franzke uploaded patch set 3 01/27/22, 19:12

  4. core-ci voted on patch set 2 V -1 01/27/22, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22590

  5. core-ci voted on patch set 3 V +1 01/27/22, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22592

  6. Benjamin Franzke rebased onto patch set 4 02/01/22, 12:33

    Rebase
  7. Benjamin Franzke wrote 02/01/22, 12:34

    Topic set to esm
  8. core-ci voted on patch set 4 V +1 02/01/22, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22871

  9. Benjamin Franzke rebased onto patch set 5 02/14/22, 09:13

    Rebase
  10. core-ci voted on patch set 5 V +1 02/14/22, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23494

  11. Benni Mack voted on patch set 5 V +1 CR +1 02/14/22, 09:35

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 02/14/22, 09:53

  13. Benjamin Franzke voted on patch set 5 V +2 CR +2 02/14/22, 10:01

  14. Benjamin Franzke merged patch set 6 02/14/22, 10:01