Review main Merged

73186[BUGFIX] Consistently use EventDispatcherInterface

Benni Mack CR +2 V +2 Normal +35 −31 updated 01/28/22, 10:46

Commit message

TYPO3 should never expose its EventDispatcher
implementation but only work with the PSR-14 interface
(SOLID principle).
Also avoid GeneralUtility::getContainer() as that's
internal and non recommended API in favor of makeInstance
where dependency injection is not yet possible.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 813

  1. Benni Mack uploaded patch set 1 01/27/22, 21:01

  2. core-ci voted on patch set 1 V +1 01/27/22, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22596

  3. Stefan Bürk updated the commit message in patch set 2 01/27/22, 21:35

  4. core-ci voted on patch set 2 V +1 01/27/22, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22598

  5. Oli Bartsch updated the commit message in patch set 3 01/27/22, 22:05

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 01/27/22, 22:05

  7. core-ci voted on patch set 3 V +1 01/27/22, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22601

  8. Benjamin Franzke uploaded patch set 4 01/28/22, 08:32

  9. core-ci voted on patch set 4 V -1 01/28/22, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22612

  10. Benjamin Franzke uploaded patch set 5 01/28/22, 09:02

  11. core-ci voted on patch set 5 V +1 01/28/22, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22613

  12. Georg Ringer voted on patch set 5 V +2 CR +2 01/28/22, 10:46

  13. Georg Ringer merged patch set 6 01/28/22, 10:46