Review 11.5 Merged

73190[BUGFIX] Consistently use EventDispatcherInterface

Benjamin Franzke CR +2 V +2 Easy +20 −20 updated 01/28/22, 13:05

Commit message

TYPO3 should never expose its EventDispatcher
implementation but only work with the PSR-14 interface
(SOLID principle).
Also avoid GeneralUtility::getContainer() as that's
internal and non recommended API in favor of makeInstance
where dependency injection is not yet possible.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 14

Review log 23

  1. Benjamin Franzke uploaded patch set 1 01/28/22, 12:31

  2. core-ci voted on patch set 1 V +1 01/28/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22619

  3. Benjamin Franzke merged patch set 2 01/28/22, 13:05