73191[FEATURE] Add composer package name to backend routes
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 3
Files 20
- typo3/sysext/backend/Classes/Module/BaseModule.php7+4 −0
- typo3/sysext/backend/Classes/Module/ExtbaseModule.php2+2 −0
- typo3/sysext/backend/Classes/Module/Module.php2+2 −0
- typo3/sysext/backend/Classes/ServiceProvider.php+5 −0
- typo3/sysext/backend/Tests/Functional/Middleware/BackendModuleValidatorTest.php+21 −5
- typo3/sysext/backend/Tests/Functional/Module/ModuleDataTest.php+1 −0
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php6+26 −3
- typo3/sysext/core/Classes/Package/PseudoServiceProvider.php+11 −2
- typo3/sysext/core/Classes/ServiceProvider.php+5 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96961-BackendRoutesContainComposerPackageName.rstnew+31 −0
- typo3/sysext/core/Tests/Unit/Hooks/TcaItemsProcessorFunctionsTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Package/Mocks/Package1ServiceProviderMock.php+5 −0
- typo3/sysext/core/Tests/Unit/Package/Mocks/Package2ServiceProviderMock.php+5 −0
- typo3/sysext/core/Tests/Unit/Package/AbstractServiceProviderTest.php+3 −0
- typo3/sysext/dashboard/Classes/ServiceProvider.php2+5 −0
- typo3/sysext/extbase/Classes/ServiceProvider.php+5 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/RequestBuilderTest.php+18 −0
- typo3/sysext/fluid/Classes/ServiceProvider.php+5 −0
- typo3/sysext/frontend/Classes/ServiceProvider.php+5 −0
- typo3/sysext/install/Classes/ServiceProvider.php+5 −0
Review log 2740
Show 1015 earlier messages
-
Christian Kuhn uploaded patch set 1 01/28/22, 13:59
-
Christian Kuhn commented on patch set 1 CR -1 01/28/22, 13:59
only half of the party ... -
core-ci voted on patch set 1 V -1 01/28/22, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22626
-
Christian Kuhn uploaded patch set 2 02/17/22, 09:07
-
core-ci voted on patch set 2 V -1 02/17/22, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23777
-
Benjamin Franzke commented on patch set 2 02/17/22, 09:19
hehe, EMU:addModule is already empty by now :) so this comment can for sure be dropped -
Christian Kuhn uploaded patch set 3 02/17/22, 14:54
-
Christian Kuhn commented on patch set 3 02/17/22, 14:55
Reply
yes. working on it. new patch already adds 'composerName' for modules, too. -
core-ci voted on patch set 3 V -1 02/17/22, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23811
-
Christian Kuhn commented on patch set 3 02/18/22, 07:44
Reply
Done -
Christian Kuhn uploaded patch set 4 02/18/22, 07:59
-
Christian Kuhn uploaded patch set 5 02/18/22, 08:00
-
core-ci voted on patch set 4 V -1 02/18/22, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23855
-
core-ci voted on patch set 5 V -1 02/18/22, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23856
-
Christian Kuhn uploaded patch set 6 02/18/22, 08:27
-
Christian Kuhn uploaded patch set 7 02/18/22, 08:30
-
core-ci voted on patch set 6 V +1 02/18/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23859
-
core-ci voted on patch set 7 V +1 02/18/22, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23861
-
Benni Mack commented on patch set 7 02/18/22, 10:01
BaseModule.php:60getPackageName() feels more consistent to other places we use composer package names.ServiceProvider.php:43can't this be resolved by the composer manifest? -
Christian Kuhn commented on patch set 7 02/18/22, 10:09
BaseModule.php:60ReplyAckServiceProvider.php:43Replyno. this is due to the way ServiceProviders are solved: they need to set it (same solution as with 'getPackagePath()' above. Only PseudoServiceProviders can do that automatically (got that solution from Benjamin). -
Christian Kuhn uploaded patch set 8 02/18/22, 10:19
-
Christian Kuhn updated the commit message in patch set 9 02/18/22, 10:20
-
Oli Bartsch commented on patch set 9 CR -1 02/18/22, 10:24
BaseModule.php:60I don't see the need to make this public API. Especially because we only need it for the getDefaultRouteOptions(). In case you insist on this method, it has to be declared in the interface.BaseModule.php:211Please secure this with a null coalescing operator and additionally cast to string, like done for the other values.ExtbaseModule.php:58I think we should just access this->composerNameAbstractServiceProvider.php:100Will fail in case $definedRoutesInPackage is not an arrayAbstractServiceProvider.php:159Will fail in case $definedModulesInPackage is not an arrayFeature-96733-NewBackendModuleRegistrationAPI.rst:263Returns the composer package name of .. But please see my comment regarding this method in the BaseModule first.Feature-96961-BackendRoutesContainComposerName.rst:18Should we use the FQDN here, since Core defines different "Route" classes? -
Christian Kuhn commented on patch set 9 02/18/22, 10:31
will take care of further notes with an additional push.BaseModule.php:211Replywhy? it's always set by the Services.AbstractServiceProvider.php:100Replyyes. and it should fail if it is not an array.AbstractServiceProvider.php:159Replyyes. and it should fail if that require does not return an array. -
core-ci voted on patch set 8 V -1 02/18/22, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23865
-
core-ci voted on patch set 9 V -1 02/18/22, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23866
-
Christian Kuhn commented on patch set 9 02/18/22, 10:42
BaseModule.php:60ReplyAckBaseModule.php:211Replyi see no need for this, but i'll do it nevertheless.ExtbaseModule.php:58ReplyDoneAbstractServiceProvider.php:100Replysanitized it.AbstractServiceProvider.php:159Replysanitized it.Feature-96733-NewBackendModuleRegistrationAPI.rst:263ReplyDoneFeature-96961-BackendRoutesContainComposerName.rst:18ReplyDone -
Christian Kuhn uploaded patch set 10 02/18/22, 10:42
-
core-ci voted on patch set 10 V +1 02/18/22, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23867
-
Benjamin Franzke commented on patch set 10 02/18/22, 11:55
Module.php:42typo3/sysext/core/Classes/Package/AbstractServiceProvider.php provides absolutePackagePath for regular routes (which is good), that should be added in here as well, otherwise these routes will miss that information. -
Christian Kuhn rebased onto patch set 11 02/18/22, 11:56
-
Oli Bartsch uploaded patch set 12 02/18/22, 12:05
-
core-ci voted on patch set 11 V +1 02/18/22, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23872
-
Oli Bartsch uploaded patch set 13 02/18/22, 12:16
-
Oli Bartsch commented on patch set 13 02/18/22, 12:16
Module.php:42ReplyDone -
core-ci voted on patch set 12 V +1 02/18/22, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23874
-
core-ci voted on patch set 13 V +1 02/18/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23875
-
Oli Bartsch voted on patch set 13 V +1 CR +1 02/18/22, 12:51
-
Benjamin Franzke voted on patch set 13 V +2 CR +2 02/18/22, 13:06
-
Benjamin Franzke merged patch set 14 02/18/22, 13:06