Review main Merged

73194[BUGFIX] Use Event.currentTarget in default_frontend.js

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 01/31/22, 13:49

Commit message

Event.target identifies the element on which the event
occurred and may a descendant of the element to which
the event handler has been attached.

Event.currentTarget instead always refers to the
element to which the event handler has been attached
and is therefore now used as source for the datasets.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Nikita Hovratov uploaded patch set 1 01/28/22, 18:33

  2. core-ci voted on patch set 1 V +1 01/28/22, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22632

  3. Benjamin Franzke updated the commit message in patch set 2 01/28/22, 19:32

  4. core-ci voted on patch set 2 V +1 01/28/22, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22633

  5. Stefan Bürk voted on patch set 2 CR +1 01/29/22, 00:14

  6. Benjamin Franzke commented on patch set 2 01/31/22, 12:06

    Can be testing by adding child elements to e-mail links, e. g. by marking some characters as bold-text and clicking on the bold text in the frontend.
  7. Oli Bartsch voted on patch set 2 V +1 CR +1 01/31/22, 13:35

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/31/22, 13:49

  9. Benjamin Franzke merged patch set 3 01/31/22, 13:49