Review main Merged

73199[TASK] Have composer/composer:^2.2 as dev dependency

Christian Kuhn CR +2 V +2 Hard +628 −166 updated 01/29/22, 19:40

Commit message

The index.php entry point handling and package
handling core scripts are composer plugins. As
such, they rely on composer. To resolve dependencies
in IDE's and phpstan, composer should be a core
monorepo dev dependency. This resolves about 50
issues from phpstan baseline.

> composer req --dev composer/composer:^2.2
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Christian Kuhn uploaded patch set 1 01/29/22, 19:15

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 01/29/22, 19:23

  3. core-ci voted on patch set 1 V +1 01/29/22, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22666

  4. Christian Kuhn commented on patch set 1 V +2 CR +2 01/29/22, 19:39

    Since this is "only" a monorepo dev dependency and since I'd say there isn't too much to discuss here or could be done much differently, I hope it is ok here to go ahead and merge this.
  5. Christian Kuhn merged patch set 2 01/29/22, 19:40