Review main Merged

73200[BUGFIX] Avoid calling ProcessedFile::getPublicUrl(true)

Stefan Bürk CR +2 V +2 Easy +1 −6 updated 01/29/22, 19:37

Commit message

$relativeToCurrentScript has been removed from
'ProcessedFile::getPublicUrl()' with #9620.

However one call to this method providing this
removed argument has been overseen, which is
done by this patch.

This also eleminates the need for phpstan ignore
rule, thus baseline is regenerated to align this.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Stefan Bürk uploaded patch set 1 01/29/22, 19:20

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 01/29/22, 19:23

  3. Stefan Bürk wrote 01/29/22, 19:24

    Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech>
  4. Stefan Bürk wrote 01/29/22, 19:24

    Removed Verified+1 by Stefan Bürk <stefan@buerk.tech>
  5. core-ci voted on patch set 1 V +1 01/29/22, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22667

  6. Christian Kuhn commented on patch set 1 V +2 CR +2 01/29/22, 19:37

    I'll merge this as de-facto no-brainer.
  7. Christian Kuhn merged patch set 2 01/29/22, 19:37