Review 11.5 Merged

73201[TASK] Have composer/composer:^2.2 as dev dependency

Christian Kuhn CR +2 V +2 Hard +628 −181 updated 01/29/22, 19:41

Commit message

The index.php entry point handling and package
handling core scripts are composer plugins. As
such, they rely on composer. To resolve dependencies
in IDE's and phpstan, composer should be a core
monorepo dev dependency. This resolves about 50
issues from phpstan baseline.

> composer req --dev composer/composer:^2.2
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/29/22, 19:20

  2. core-ci voted on patch set 1 V +1 01/29/22, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22668

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 01/29/22, 19:38

  4. Oliver Klee voted on patch set 1 CR +1 01/29/22, 19:40

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/29/22, 19:41

  6. Christian Kuhn merged patch set 2 01/29/22, 19:41