Review main Merged

73202[TASK] Avoid typehint docblocks for FunctionalTestCase properties

Stefan Bürk CR +2 V +2 Hard +3 −621 updated 01/30/22, 00:05

Commit message

This patch removes docblock typehints for FunctionalTestCase
properties in functional tests, thus using the docblock type
hint of base class:

* $coreExtensionsToLoad
* $testExtensionsToLoad
* $pathsToLinkInTestInstance
* $pathsToProvideInTestInstance

This resolves a couple of issues from phpstan baseline.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 75

Show 55 more files

Review log 1424

  1. Stefan Bürk uploaded patch set 1 01/29/22, 20:33

  2. Stefan Bürk updated the commit message in patch set 2 01/29/22, 20:34

  3. core-ci voted on patch set 1 V +1 01/29/22, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22669

  4. core-ci voted on patch set 2 V +1 01/29/22, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22670

  5. Stefan Bürk commented on patch set 2 CR -1 01/29/22, 21:11

    slipped in new variants through inheritance .. will recheck
  6. Stefan Bürk uploaded patch set 3 01/29/22, 21:23

  7. core-ci voted on patch set 3 V +1 01/29/22, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22677

  8. Stefan Bürk uploaded patch set 4 01/29/22, 21:57

  9. Stefan Bürk voted on patch set 4 CR -1 01/29/22, 22:03

  10. core-ci voted on patch set 4 V +1 01/29/22, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22685

  11. Stefan Bürk uploaded patch set 5 01/29/22, 22:36

  12. Stefan Bürk updated the commit message in patch set 6 01/29/22, 22:44

  13. Stefan Bürk updated the commit message in patch set 7 01/29/22, 22:45

  14. core-ci voted on patch set 5 V +1 01/29/22, 22:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22687

  15. core-ci voted on patch set 6 V +1 01/29/22, 22:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22690

  16. core-ci voted on patch set 7 V +1 01/29/22, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22691

  17. Stefan Bürk uploaded patch set 8 01/29/22, 23:30

  18. Christian Kuhn updated the commit message in patch set 9 01/29/22, 23:39

  19. core-ci voted on patch set 8 V +1 01/29/22, 23:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22694

  20. Christian Kuhn uploaded patch set 10 01/29/22, 23:46

  21. core-ci voted on patch set 9 V +1 01/29/22, 23:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22697

  22. core-ci voted on patch set 10 V +1 01/29/22, 23:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22699

  23. Christian Kuhn commented on patch set 10 V +2 CR +2 01/30/22, 00:04

    Since this is strictly only test & test-comment related: I'll merge this now.
  24. Christian Kuhn merged patch set 11 01/30/22, 00:05