73203[TASK] Avoid typehint docblocks for FunctionalTestCase properties
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 1
Files 75
- Build/phpstan/phpstan-baseline.neon+0 −375
- typo3/sysext/backend/Tests/Functional/Clipboard/ClipboardTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/Controller/Page/LocalizationControllerTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Cache/Core/ClassAliasLoaderTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.php+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SecurityTest.php+0 −3
- typo3/sysext/core/Tests/Functional/IO/PharStreamWrapperInterceptorTest.php+0 −2
- typo3/sysext/core/Tests/Functional/Utility/RootlineUtilityTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Pagination/QueryResultPaginatorTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapFactoryTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+0 −3
Show 55 more files
- typo3/sysext/extbase/Tests/Functional/Persistence/CountTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/EnableFieldsTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/ImplementationClassNameTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/InTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/IsDirtyTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/OperatorTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryLocalizedDataTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php+0 −4
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php+0 −6
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/WorkspaceTest.php+0 −6
- typo3/sysext/extbase/Tests/Functional/Service/ExtensionServiceTest.php+1 −3
- typo3/sysext/felogin/Tests/Functional/Domain/Repository/FrontendUserGroupRepositoryTest.php+0 −3
- typo3/sysext/felogin/Tests/Functional/Domain/Repository/FrontendUserRepositoryTest.php+0 −3
- typo3/sysext/felogin/Tests/Functional/Tca/ContentVisibleFieldsTest.php+0 −3
- typo3/sysext/filemetadata/Tests/Functional/Tca/FileMetadataVisibleFieldsTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+1 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/FileViewHelperTest.php+0 −6
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/SecureHtmlRenderingTest.php+0 −3
- typo3/sysext/fluid_styled_content/Tests/Functional/Tca/ContentVisibleFieldsTest.php+0 −3
- typo3/sysext/fluid_styled_content/Tests/FunctionalDeprecated/Rendering/SecureHtmlRenderingTest.php+0 −3
- typo3/sysext/form/Tests/Functional/Mvc/Validation/MimeTypeValidatorTest.php+0 −3
- typo3/sysext/frontend/Tests/Functional/ContentObject/FluidTemplateContentObjectTest.php+0 −3
- typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php+0 −6
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+0 −3
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+0 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Export/ExportPageTreeViewTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentTest.php+0 −6
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithImagesTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithRelationsAndSoftrefsTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Import/IrreTutorialRecordsTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+0 −3
- typo3/sysext/impexp/Tests/Functional/ExportTest.php+0 −6
- typo3/sysext/impexp/Tests/Functional/ImportExportTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+0 −3
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/WorkspaceNewPlaceholderRemovalTest.php+0 −3
- typo3/sysext/install/Tests/Functional/Updates/ShortcutRecordsMigrationTest.php+1 −4
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+0 −3
- typo3/sysext/recycler/Tests/Functional/Recycle/AbstractRecycleTestCase.php+0 −3
- typo3/sysext/redirects/Tests/Functional/Service/IntegrityServiceTest.php+0 −3
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+0 −3
- typo3/sysext/scheduler/Tests/Functional/Tca/TaskGroupVisibleFieldsTest.php+0 −3
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+0 −3
- typo3/sysext/seo/Tests/Functional/HrefLang/HrefLangGeneratorTest.php+0 −3
- typo3/sysext/seo/Tests/Functional/XmlSitemap/AbstractXmlSitemapPagesTest.php+0 −3
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapIndexTest.php+0 −3
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapRecordsTest.php+0 −3
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapXslTest.php+0 −3
- typo3/sysext/sys_note/Tests/Functional/Tca/NoteVisibleFieldsTest.php+0 −3
- typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php+0 −3
- typo3/sysext/workspaces/Tests/Functional/Tca/WorkspaceStageVisibleFieldsTest.php+0 −3
- typo3/sysext/workspaces/Tests/Functional/Tca/WorkspaceVisibleFieldsTest.php+0 −3
Review log 1117
-
Stefan Bürk uploaded patch set 1 01/29/22, 20:54
-
Stefan Bürk commented on patch set 1 01/29/22, 20:55
- solved cherry-pick merge conflict in: > typo3/sysext/install/Tests/Functional/Updates/RowUpdater/WorkspaceNewPlaceholderRemovalTest.php - removed from cherry-pick as not existing in v11: > git rm typo3/sysext/form/Tests/Functional/ViewHelpers/UploadedResourceViewHelperTest.php - additional docblock addes as not exiting in v12: > typo3/sysext/extbase/Tests/Functional/Persistence/ImplementationClassNameTest.php - regenerated baseline: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline -
core-ci voted on patch set 1 V +1 01/29/22, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22671
-
Stefan Bürk voted on patch set 1 CR -1 01/29/22, 21:11
-
Stefan Bürk uploaded patch set 2 01/29/22, 21:27
-
core-ci voted on patch set 2 V +1 01/29/22, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22679
-
Stefan Bürk uploaded patch set 3 01/29/22, 21:59
-
Stefan Bürk voted on patch set 3 CR -1 01/29/22, 22:03
-
core-ci voted on patch set 3 V +1 01/29/22, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22686
-
Stefan Bürk uploaded patch set 4 01/29/22, 23:29
-
core-ci voted on patch set 4 V +1 01/29/22, 23:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22693
-
Christian Kuhn updated the commit message in patch set 5 01/29/22, 23:40
-
Christian Kuhn uploaded patch set 6 01/29/22, 23:48
-
core-ci voted on patch set 5 V +1 01/29/22, 23:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22698
-
core-ci voted on patch set 6 V +1 01/30/22, 00:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22700
-
Christian Kuhn voted on patch set 6 V +2 CR +2 01/30/22, 00:05
-
Christian Kuhn merged patch set 7 01/30/22, 00:05