Review 11.5 Merged

73203[TASK] Avoid typehint docblocks for FunctionalTestCase properties

Stefan Bürk CR +2 V +2 Hard +3 −616 updated 01/30/22, 00:05

Commit message

This patch removes docblock typehints for FunctionalTestCase
properties in functional tests, thus using the docblock type
hint of base class:

* $coreExtensionsToLoad
* $testExtensionsToLoad
* $pathsToLinkInTestInstance
* $pathsToProvideInTestInstance

This resolves a couple of issues from phpstan baseline.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 75

Show 55 more files

Review log 1117

  1. Stefan Bürk uploaded patch set 1 01/29/22, 20:54

  2. Stefan Bürk commented on patch set 1 01/29/22, 20:55

    - solved cherry-pick merge conflict in: > typo3/sysext/install/Tests/Functional/Updates/RowUpdater/WorkspaceNewPlaceholderRemovalTest.php - removed from cherry-pick as not existing in v11: > git rm typo3/sysext/form/Tests/Functional/ViewHelpers/UploadedResourceViewHelperTest.php - additional docblock addes as not exiting in v12: > typo3/sysext/extbase/Tests/Functional/Persistence/ImplementationClassNameTest.php - regenerated baseline: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline
  3. core-ci voted on patch set 1 V +1 01/29/22, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22671

  4. Stefan Bürk voted on patch set 1 CR -1 01/29/22, 21:11

  5. Stefan Bürk uploaded patch set 2 01/29/22, 21:27

  6. core-ci voted on patch set 2 V +1 01/29/22, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22679

  7. Stefan Bürk uploaded patch set 3 01/29/22, 21:59

  8. Stefan Bürk voted on patch set 3 CR -1 01/29/22, 22:03

  9. core-ci voted on patch set 3 V +1 01/29/22, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22686

  10. Stefan Bürk uploaded patch set 4 01/29/22, 23:29

  11. core-ci voted on patch set 4 V +1 01/29/22, 23:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22693

  12. Christian Kuhn updated the commit message in patch set 5 01/29/22, 23:40

  13. Christian Kuhn uploaded patch set 6 01/29/22, 23:48

  14. core-ci voted on patch set 5 V +1 01/29/22, 23:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22698

  15. core-ci voted on patch set 6 V +1 01/30/22, 00:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22700

  16. Christian Kuhn voted on patch set 6 V +2 CR +2 01/30/22, 00:05

  17. Christian Kuhn merged patch set 7 01/30/22, 00:05