Review main Merged

73204[TASK] Tests: Have defined LANGUAGE_PRESETS

Christian Kuhn CR +2 V +2 Normal +19 −58 updated 01/29/22, 21:29

Commit message

Constant LANGUAGE_PRESETS must be defined in tests
using SiteBasedTestTrait and needs to be accessible.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 45

  1. Christian Kuhn uploaded patch set 1 01/29/22, 20:59

  2. core-ci voted on patch set 1 V +1 01/29/22, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22672

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 01/29/22, 21:14

  4. Christian Kuhn commented on patch set 1 V +2 CR +2 01/29/22, 21:29

    With v12 & v11 CI being happy with this, and considering this is "test only cleanup", I'll merge this now.
  5. Christian Kuhn merged patch set 2 01/29/22, 21:29