73209[TASK] Tests: Avoid a couple of obvious code inconsistencies
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- Build/phpstan/phpstan-baseline.neon+0 −30
- typo3/sysext/backend/Tests/Unit/Form/Fixtures/NodeFactory/NodeElements/BarElement.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/Fixtures/NodeFactory/NodeElements/FooElement.php+2 −2
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/WorkspaceNewPlaceholderRemovalTest.php+2 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/Service/IntegrityServiceTest.php+0 −2
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+1 −1
Review log 79
-
Christian Kuhn uploaded patch set 1 01/29/22, 21:26
-
core-ci voted on patch set 1 V -1 01/29/22, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22678
-
Christian Kuhn uploaded patch set 2 01/29/22, 21:35
-
Oliver Klee voted on patch set 2 CR +1 01/29/22, 21:36
-
Stefan Bürk voted on patch set 2 V +1 CR +1 01/29/22, 21:44
-
core-ci voted on patch set 2 V +1 01/29/22, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22681
-
Christian Kuhn commented on patch set 2 01/29/22, 21:51
With CI being green and phpstan being more happy with this, I'll merge the patch now. -
Christian Kuhn voted on patch set 2 V +2 CR +2 01/29/22, 21:51
-
Christian Kuhn merged patch set 3 01/29/22, 21:51