Review main Merged

73209[TASK] Tests: Avoid a couple of obvious code inconsistencies

Christian Kuhn CR +2 V +2 Easy +8 −38 updated 01/29/22, 21:51

Commit message

* Too many arguments to __construct()
* Inconsistent naming
* Undeclared properties

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/29/22, 21:26

  2. core-ci voted on patch set 1 V -1 01/29/22, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22678

  3. Christian Kuhn uploaded patch set 2 01/29/22, 21:35

  4. Oliver Klee voted on patch set 2 CR +1 01/29/22, 21:36

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 01/29/22, 21:44

  6. core-ci voted on patch set 2 V +1 01/29/22, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22681

  7. Christian Kuhn commented on patch set 2 01/29/22, 21:51

    With CI being green and phpstan being more happy with this, I'll merge the patch now.
  8. Christian Kuhn voted on patch set 2 V +2 CR +2 01/29/22, 21:51

  9. Christian Kuhn merged patch set 3 01/29/22, 21:51