Review main Merged

73211[TASK] Tests: Have jangregor/phpstan-prophecy:^1.0

Christian Kuhn CR +2 V +2 Nightmare +106 −3914 updated 01/29/22, 23:04

Commit message

Having jangregor/phpstan-prophecy and including it
in the phpstan config cuts the baseline by ~half.
Details can now be sorted out with single patches.

> composer req --dev jangregor/phpstan-prophecy:^1.0
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Christian Kuhn uploaded patch set 1 01/29/22, 22:40

  2. Christian Kuhn updated the commit message in patch set 2 01/29/22, 22:41

  3. core-ci voted on patch set 1 V +1 01/29/22, 22:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22688

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 01/29/22, 22:56

  5. core-ci voted on patch set 2 V +1 01/29/22, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22689

  6. Christian Kuhn commented on patch set 2 V +2 CR +2 01/29/22, 23:04

    i'll merge this since this is "just" another phpstan dev dependency for now that reduces baseline without any code changes.
  7. Christian Kuhn merged patch set 3 01/29/22, 23:04