Review 11.5 Merged

73212[TASK] Tests: Have jangregor/phpstan-prophecy:^1.0

Christian Kuhn CR +2 V +2 Nightmare +106 −3934 updated 01/29/22, 23:06

Commit message

Having jangregor/phpstan-prophecy and including it
in the phpstan config cuts the baseline by ~half.
Details can now be sorted out with single patches.

> composer req --dev jangregor/phpstan-prophecy:^1.0
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2

Issues 1

Files 4

Review log 45

  1. Christian Kuhn uploaded patch set 1 01/29/22, 22:47

  2. Stefan Bürk voted on patch set 1 CR +1 01/29/22, 22:57

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/29/22, 23:05

  4. Christian Kuhn merged patch set 2 01/29/22, 23:05

  5. core-ci voted on patch set 1 V +1 01/29/22, 23:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22692