Review main Merged

73213[TASK] Avoid state and undefined properties in tests

Christian Kuhn CR +2 V +2 Easy +14 −35 updated 01/30/22, 00:06

Commit message

There is often no point in having test class state
which may lead to undefined class properties and
more complex test setups.

The patch simplifies a test to show this is more
easy to grasp and solve a phpstan error along the way.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Christian Kuhn uploaded patch set 1 01/29/22, 23:32

  2. core-ci voted on patch set 1 V -1 01/29/22, 23:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22695

  3. core-ci voted on patch set 1 V +1 01/29/22, 23:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22695

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 01/30/22, 00:05

  5. Christian Kuhn commented on patch set 1 V +2 CR +2 01/30/22, 00:06

    i'll merge this since this a rather straight test-only refactoring.
  6. Christian Kuhn merged patch set 2 01/30/22, 00:06