Review main Merged Breaking

73216[!!!][TASK] Remove built-in support for accesskeys in HMENU

Benni Mack CR +2 V +2 Normal +61 −54 updated 01/31/22, 13:06

Commit message

The HTML standard "accesskey" is built into TYPO3's
HMENU functionality, with only limited support:

* No cross-platform labeling possible
* No concrete definition possible via TypoScript (AccessPad)
* Random access based on the menu items' title
* Legacy implementation based on TSFE state

In addition, proper browser support has been poorly,
and it is only recommended for specific use-cases,
not really for a11y purposes.

For this reason, this feature is removed as is, and
should be implemented in the TYPO3 Frontend when it is
needed in custom extensions or via JavaScript support:

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey#accessibility_concerns
https://webaim.org/standards/wcag/checklist#:~:text=accesskey%20should%20typically%20be%20avoided

The HMENU property "accessKey" will stop working
in TYPO3 v12.0.

Side-note: An additional, leftover reference ("collapse") in tsref.xml
was also removed for HMENU.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1014

  1. Benni Mack uploaded patch set 1 01/30/22, 07:46

  2. core-ci voted on patch set 1 V +1 01/30/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22705

  3. Michael Telgkamp commented on patch set 1 V -1 CR +1 01/31/22, 09:17

    The code change looks fine, but documentation needs to be added.
  4. Benni Mack updated the commit message in patch set 2 01/31/22, 10:48

  5. core-ci voted on patch set 2 V +1 01/31/22, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22788

  6. Benni Mack uploaded patch set 3 01/31/22, 11:59

  7. core-ci voted on patch set 3 V +1 01/31/22, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22795

  8. Georg Ringer voted on patch set 3 V +1 CR +1 01/31/22, 12:34

  9. Oli Bartsch uploaded patch set 4 01/31/22, 12:52

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 01/31/22, 12:53

  11. Georg Ringer voted on patch set 4 V +1 CR +1 01/31/22, 13:00

  12. core-ci voted on patch set 4 V +1 01/31/22, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22801

  13. Benjamin Franzke voted on patch set 4 V +2 CR +2 01/31/22, 13:06

  14. Benjamin Franzke merged patch set 5 01/31/22, 13:06