Review main Merged

73218[BUGFIX] Fix "undefined array key" issues in LiveSearch's page jump

Andreas Kienast CR +2 V +2 Easy +8 −8 updated 01/31/22, 06:51

Commit message

This patch adds a few null-coalesce conditions in the LiveSearch in case
a field not defined in TCA (in most cases uid and pid) is queried, which
is the case when using the "page jump" feature.

As a drive-by, these issues are fixed as well:
* Pass `$queryBuilder` as a reference, which makes no sense for objects
* Adding SQL constraints twice

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Andreas Kienast uploaded patch set 1 01/30/22, 12:10

  2. core-ci voted on patch set 1 V +1 01/30/22, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22711

  3. Stefan Bürk voted on patch set 1 CR +1 01/30/22, 12:43

  4. Stefan Bürk wrote 01/30/22, 12:55

    Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech>
  5. Stefan Bürk commented on patch set 1 01/30/22, 12:55

    LiveSearch.php:337

    Using reference here should be avoided, as no writing access needed. Fallback should be added here too.

    LiveSearch.php:338

    here too
  6. Andreas Kienast uploaded patch set 2 01/30/22, 12:57

  7. Stefan Bürk commented on patch set 2 V +1 CR +1 01/30/22, 13:09

    LiveSearch.php:337 Reply

    Done

    LiveSearch.php:338 Reply

    Done
  8. core-ci voted on patch set 2 V +1 01/30/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22713

  9. Benni Mack voted on patch set 2 V +1 CR +1 01/30/22, 13:19

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 01/31/22, 06:51

  11. Andreas Kienast merged patch set 3 01/31/22, 06:51