Review main Merged

73219[TASK] Add PHPStan plugin for PHPUnit

Oliver Klee CR +2 V +2 Hard +132 −710 updated 01/30/22, 15:50

Commit message

Adding phpstan/phpstan-phpunit makes phpstan
"understand" mocking and a couple of related things.

Loading the extension in phpstan.neon reduces removes
a bunch of PHPStan warnings, makes others more specific,
and adds new warnings for some PHPUnit-specific issues.

> composer require --dev phpstan/phpstan-phpunit:^1.0

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2028

Show 3 earlier messages
  1. Oliver Klee uploaded patch set 1 01/30/22, 13:27

  2. Oliver Klee updated the commit message in patch set 2 01/30/22, 13:28

  3. Oliver Klee updated the commit message in patch set 3 01/30/22, 13:29

  1. Christian Kuhn commented on patch set 3 CR -1 01/30/22, 13:36

    working on a similar thing. But i'd prefer to leave out phpstan-installer ... this is just about those couple of lines to load the config files of extensions ... let's please keep that manual, it's more transparent having that in the .neon file.
  2. core-ci voted on patch set 2 V +1 01/30/22, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22715

  3. core-ci voted on patch set 1 V +1 01/30/22, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22714

  4. core-ci voted on patch set 3 V +1 01/30/22, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22716

  5. Oliver Klee uploaded patch set 4 01/30/22, 13:48

  6. Oliver Klee uploaded patch set 5 01/30/22, 13:49

  7. Oliver Klee commented on patch set 5 01/30/22, 13:53

    Reply

    Done.
  8. core-ci voted on patch set 4 V +1 01/30/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22717

  9. core-ci voted on patch set 5 V +1 01/30/22, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22718

  10. Christian Kuhn uploaded patch set 6 01/30/22, 15:09

  11. Stefan Bürk updated the commit message in patch set 7 01/30/22, 15:15

  12. core-ci voted on patch set 6 V +1 01/30/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22720

  13. core-ci voted on patch set 7 V +1 01/30/22, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22721

  14. Christian Kuhn updated the commit message in patch set 8 01/30/22, 15:25

  15. Oliver Klee voted on patch set 8 CR +1 01/30/22, 15:26

  16. Benjamin Franzke voted on patch set 8 V +1 CR +1 01/30/22, 15:34

  17. Benjamin Franzke voted on patch set 8 V 0 CR 0 01/30/22, 15:38

  18. core-ci voted on patch set 8 V +1 01/30/22, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22724

  19. Christian Kuhn voted on patch set 8 V +2 CR +2 01/30/22, 15:43

  20. Stefan Bürk voted on patch set 8 V +1 CR +1 01/30/22, 15:43

  21. Christian Kuhn voted on patch set 8 V +1 CR +1 01/30/22, 15:43

  22. Christian Kuhn voted on patch set 8 V +2 CR +2 01/30/22, 15:44

  23. Benjamin Franzke commented on patch set 8 CR -1 01/30/22, 15:44

    on it
  24. Christian Kuhn merged patch set 9 01/30/22, 15:44

  25. Benjamin Franzke commented on patch set 9 V +1 CR +1 01/30/22, 15:50

    all fine.