Review main Merged

73220[TASK] Add PHPStan plugin for psr/container

Benjamin Franzke CR +2 V +2 Normal +64 −20 updated 01/30/22, 16:04

Commit message

The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in core ServiceProviders once we enable phpstan level 5
as invalid parameter usage will then be detected.

The plugin already revealed wrong interface usage in
functional MFA tests which are fixed as a drive by.

Commands executed:

  composer req --dev bnf/phpstan-psr-container:^1.0
  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1012

  1. Benjamin Franzke uploaded patch set 1 01/30/22, 15:22

  2. Oliver Klee voted on patch set 1 CR +1 01/30/22, 15:28

  3. Christian Kuhn commented on patch set 1 01/30/22, 15:29

    cool! let's first merge the phpunit patch, then rebase here. can take care.
  4. Benjamin Franzke commented on patch set 1 01/30/22, 15:30

    Reply

    ack, will rebase.
  5. Benjamin Franzke uploaded patch set 2 01/30/22, 15:36

  6. core-ci voted on patch set 1 V +1 01/30/22, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22722

  7. Benjamin Franzke uploaded patch set 3 01/30/22, 15:47

  8. Benjamin Franzke uploaded patch set 4 01/30/22, 15:52

  9. core-ci voted on patch set 4 V +1 01/30/22, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22729

  10. Christian Kuhn voted on patch set 4 V +2 CR +2 01/30/22, 16:03

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 01/30/22, 16:03

  12. Christian Kuhn merged patch set 5 01/30/22, 16:04