Review 11.5 Merged

73221[TASK] Add PHPStan plugin for PHPUnit

Christian Kuhn CR +2 V +2 Hard +143 −721 updated 01/30/22, 15:44

Commit message

Adding phpstan/phpstan-phpunit makes phpstan
"understand" mocking and a couple of related things.

Loading the extension in phpstan.neon reduces removes
a bunch of PHPStan warnings, makes others more specific,
and adds new warnings for some PHPUnit-specific issues.

> composer require --dev phpstan/phpstan-phpunit:^1.0

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 78

  1. Christian Kuhn uploaded patch set 1 01/30/22, 15:24

  2. Christian Kuhn updated the commit message in patch set 2 01/30/22, 15:25

  3. Christian Kuhn updated the commit message in patch set 3 01/30/22, 15:25

  4. Oliver Klee voted on patch set 3 CR +1 01/30/22, 15:27

  5. core-ci voted on patch set 3 V +1 01/30/22, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22726

  6. Stefan Bürk voted on patch set 3 V +1 CR +1 01/30/22, 15:43

  7. Christian Kuhn voted on patch set 3 V +2 CR +2 01/30/22, 15:44

  8. Christian Kuhn merged patch set 4 01/30/22, 15:44