Review 11.5 Merged

73222[TASK] Add PHPStan plugin for psr/container

Christian Kuhn CR +2 V +2 Normal +83 −19 updated 01/30/22, 17:25

Commit message

The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in core ServiceProviders once we enable phpstan level 5
as invalid parameter usage will then be detected.

The plugin already revealed wrong interface usage in
functional MFA tests which are fixed as a drive by.

Commands executed:

  composer req --dev bnf/phpstan-psr-container:^1.0
  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 67

  1. Christian Kuhn uploaded patch set 1 01/30/22, 16:07

  2. Oliver Klee voted on patch set 1 CR +1 01/30/22, 16:09

  3. Stefan Bürk voted on patch set 1 CR +1 01/30/22, 16:17

  4. core-ci voted on patch set 1 V +1 01/30/22, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22730

  5. Stefan Bürk voted on patch set 1 V +1 01/30/22, 16:20

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 01/30/22, 17:24

  7. Christian Kuhn merged patch set 2 01/30/22, 17:25