73223[TASK] Avoid phpstan 'PHPDoc tag @var has invalid value' errors
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 32
- Build/phpstan/phpstan-baseline.neon+11 −866
- typo3/sysext/core/Tests/Functional/Authentication/BackendUserAuthenticationTest.php+3 −7
- typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php+2 −5
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+2 −2
- typo3/sysext/core/Tests/Unit/Authentication/AbstractUserAuthenticationTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+8 −9
- typo3/sysext/core/Tests/Unit/Error/ProductionExceptionHandlerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractMemoryTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Log/LoggerTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+4 −2
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+3 −8
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+4 −12
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+4 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+9 −13
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php+0 −1
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+0 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/FluidTemplateContentObjectTest.php+0 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+0 −1
Show 12 more files
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+0 −3
- typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php+20 −20
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+27 −29
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+39 −39
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php+21 −21
- typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php+12 −12
- typo3/sysext/install/Tests/Unit/FolderStructure/StructureFacadeTest.php+2 −2
- typo3/sysext/install/Tests/Unit/Service/CoreUpdateServiceTest.php+4 −4
- typo3/sysext/install/Tests/Unit/Service/CoreVersionServiceTest.php+2 −2
- typo3/sysext/install/Tests/Unit/Service/EnableFileServiceTest.php+2 −2
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+14 −14
- typo3/sysext/recycler/Tests/Functional/Recycle/AbstractRecycleTestCase.php+2 −4
Review log 57
-
Christian Kuhn uploaded patch set 1 01/30/22, 17:20
-
core-ci voted on patch set 1 V -1 01/30/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22731
-
Christian Kuhn uploaded patch set 2 01/30/22, 17:26
-
core-ci voted on patch set 2 V +1 01/30/22, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22732
-
Stefan Bürk voted on patch set 2 V +1 CR +1 01/30/22, 17:39
-
Christian Kuhn commented on patch set 2 V +2 CR +2 01/30/22, 17:59
considering this is strictly 'tests-only' and 'comments-only', I'll go ahead and merge this even with only one person vote - CI & phpstan are happy ... what could possibly go wrong ;) -
Christian Kuhn merged patch set 3 01/30/22, 18:03