Review main Merged

73223[TASK] Avoid phpstan 'PHPDoc tag @var has invalid value' errors

Christian Kuhn CR +2 V +2 Expert +202 −1095 updated 01/30/22, 18:03

Commit message

Annotations are sometimes:
/** @var $foo MyType */
But should be:
/** @var MyType $foo */

The patch fixes this in all tests: getMock() and
createMock() need no annotation at all (both phpstan and
phpstorm understand this), getAccessibleMock() currently
needs an annotation and then sometimes mumbles about
obsolete arguments for _call(), which can be adapted
with another patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 57

  1. Christian Kuhn uploaded patch set 1 01/30/22, 17:20

  2. core-ci voted on patch set 1 V -1 01/30/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22731

  3. Christian Kuhn uploaded patch set 2 01/30/22, 17:26

  4. core-ci voted on patch set 2 V +1 01/30/22, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22732

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 01/30/22, 17:39

  6. Christian Kuhn commented on patch set 2 V +2 CR +2 01/30/22, 17:59

    considering this is strictly 'tests-only' and 'comments-only', I'll go ahead and merge this even with only one person vote - CI & phpstan are happy ... what could possibly go wrong ;)
  7. Christian Kuhn merged patch set 3 01/30/22, 18:03