Review 11.5 Merged

73224[TASK] Avoid phpstan 'PHPDoc tag @var has invalid value' errors

Christian Kuhn CR +2 V +2 Expert +202 −1125 updated 01/30/22, 18:03

Commit message

Annotations are sometimes:
/** @var $foo MyType */
But should be:
/** @var MyType $foo */

The patch fixes this in all tests: getMock() and
createMock() need no annotation at all (both phpstan and
phpstorm understand this), getAccessibleMock() currently
needs an annotation and then sometimes mumbles about
obsolete arguments for _call(), which can be adapted
with another patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 37

Show 17 more files

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/30/22, 17:44

  2. Stefan Bürk voted on patch set 1 CR +1 01/30/22, 17:48

  3. core-ci voted on patch set 1 V +1 01/30/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22733

  4. Stefan Bürk voted on patch set 1 V +1 01/30/22, 17:57

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/30/22, 18:03

  6. Christian Kuhn merged patch set 2 01/30/22, 18:03