Review main Merged

73225[TASK] Remove superfluous null coalescing operator

Torben Hansen CR +2 V +2 Easy +1 −6 updated 01/30/22, 18:04

Commit message

Remove a superfluous null coalescing operator in
AbstractConfigurationManager since the $conf variable
is always an array.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Torben Hansen uploaded patch set 1 01/30/22, 17:44

  2. Oliver Klee voted on patch set 1 CR +1 01/30/22, 17:47

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 01/30/22, 17:47

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 01/30/22, 17:49

  5. Stefan Bürk updated the commit message in patch set 2 01/30/22, 17:52

  6. Stefan Bürk commented on patch set 2 V +1 CR +1 01/30/22, 17:52

    11.5 backport is safe and should be done also.
  7. core-ci voted on patch set 1 V +1 01/30/22, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22734

  8. core-ci voted on patch set 2 V +1 01/30/22, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22735

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 01/30/22, 18:03

  10. Christian Kuhn merged patch set 3 01/30/22, 18:04