Review main Merged

73227[TASK] Fix doc comment in fixture BlogController::processRequest

Torben Hansen CR +2 V +2 Easy +0 −7 updated 01/30/22, 20:57

Commit message

Fixes the doc comment for processRequest in BlogController by
removing annotations that are already explained by the
method signature.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Torben Hansen uploaded patch set 1 01/30/22, 18:49

  2. Christian Kuhn commented on patch set 1 01/30/22, 19:03

    BlogController.php:108

    please just drop both the @param and @return: these two don't add value since the method signature says *exactly* the same.
  3. core-ci voted on patch set 1 V +1 01/30/22, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22737

  4. Torben Hansen uploaded patch set 2 01/30/22, 19:22

  5. Torben Hansen commented on patch set 2 01/30/22, 19:23

    BlogController.php:108 Reply

    Done
  6. core-ci voted on patch set 2 V +1 01/30/22, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22741

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/30/22, 19:49

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 01/30/22, 20:57

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 01/30/22, 20:57

  10. Christian Kuhn merged patch set 3 01/30/22, 20:57