73228[TASK] Resolve some 'access to undefined property' in tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 10
- Build/phpstan/phpstan-baseline.neon+0 −45
- typo3/sysext/backend/Tests/Functional/Authentication/PasswordResetTest.php+4 −1
- typo3/sysext/core/Tests/Unit/EventDispatcher/EventDispatcherTest.php+3 −6
- typo3/sysext/extbase/Tests/Functional/Service/ExtensionServiceTest.php+1 −8
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+0 −27
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+1 −0
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/IntegerValidatorTest.php+8 −24
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NotEmptyValidatorTest.php+17 −19
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/TextValidatorTest.php+4 −12
Review log 1113
-
Christian Kuhn uploaded patch set 1 01/30/22, 18:50
-
core-ci voted on patch set 1 V +1 01/30/22, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22738
-
Oliver Klee commented on patch set 1 01/30/22, 19:06
-
Christian Kuhn commented on patch set 1 01/30/22, 19:15
AdminPanelInitiatorTest.php:62Replytried that. did not work. imho the phpstan prophecy plugin is incomplete when *properties* of prophec'ied classes are changed. could you play around on that a bit and come up with something better that works? i failed to do so and left the other places as is (for instance the very same thing in ConfigurationServiceTest.php. -
Oliver Klee commented on patch set 1 01/30/22, 19:19
AdminPanelInitiatorTest.php:62ReplyYes, I will have a try. -
Christian Kuhn commented on patch set 1 01/30/22, 21:37
AdminPanelInitiatorTest.php:62Replyi'll drop this one from the patch for now - phpstan-prophecy imho needs some love for this. -
Christian Kuhn uploaded patch set 2 01/30/22, 21:38
-
Christian Kuhn commented on patch set 2 01/30/22, 21:39
AdminPanelInitiatorTest.php:62ReplyDone -
core-ci voted on patch set 2 V +1 01/30/22, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22751
-
Jochen Roth voted on patch set 2 V +1 CR +1 01/30/22, 21:54
-
Stefan Bürk voted on patch set 2 V +1 CR +1 01/30/22, 21:55
-
Christian Kuhn voted on patch set 2 V +2 CR +2 01/30/22, 21:56
-
Christian Kuhn merged patch set 3 01/30/22, 21:56
AdminPanelInitiatorTest.php:62