Review main Merged

73230[TASK] Update doc comment for ActionController::getErrorFlashMessage

Torben Hansen CR +2 V +2 Easy +1 −6 updated 01/30/22, 21:17

Commit message

The function getErrorFlashMessage() in ActionController can either
return a string or a boolean. This patch adds bool as allowed
return type in the doc comment.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Torben Hansen uploaded patch set 1 01/30/22, 19:12

  2. core-ci voted on patch set 1 V +1 01/30/22, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22740

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 01/30/22, 19:50

  4. Christian Kuhn uploaded patch set 2 01/30/22, 21:01

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 01/30/22, 21:12

  6. core-ci voted on patch set 2 V +1 01/30/22, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22748

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 01/30/22, 21:16

  8. Christian Kuhn merged patch set 3 01/30/22, 21:17