Review 11.5 Merged

73233[TASK] Avoid phpstan 'PHPDoc tag @param has invalid value' errors

Stefan Bürk CR +2 V +2 Hard +57 −614 updated 01/30/22, 23:01

Commit message

Annotations are sometimes:
/** @param $foo */
/** @param $foo MyType */

But should be (at least):
/** @param MyType $foo */

Using argument typehints are the preferred solution.
'@param' docblock annotations are removed if argument
type hints can be set or has been already set.

Two test classes with broken syntax are added to
phpstan exclude configuration as this is for testing
purposes and can not be disabled otherwise.
Having them as ignore patterns should be avoided.

Generated baseline with:
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 37

Show 17 more files

Review log 813

  1. Stefan Bürk uploaded patch set 1 01/30/22, 21:44

  2. core-ci voted on patch set 1 V -1 01/30/22, 21:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22753

  3. Stefan Bürk uploaded patch set 2 01/30/22, 22:03

  4. Stefan Bürk uploaded patch set 3 01/30/22, 22:17

  5. core-ci voted on patch set 2 V -1 01/30/22, 22:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22755

  6. Stefan Bürk uploaded patch set 4 01/30/22, 22:29

  7. core-ci voted on patch set 4 V -1 01/30/22, 22:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22759

  8. Stefan Bürk uploaded patch set 5 01/30/22, 22:45

  9. Christian Kuhn uploaded patch set 6 01/30/22, 22:47

  10. core-ci voted on patch set 5 V +1 01/30/22, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22760

  11. Christian Kuhn voted on patch set 6 V +2 CR +2 01/30/22, 22:58

  12. Christian Kuhn merged patch set 7 01/30/22, 22:58

  13. core-ci voted on patch set 6 V +1 01/30/22, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22761