Review main Merged

73237[TASK] Accessible mocks understand _call() arguments

Christian Kuhn CR +2 V +2 Normal +4 −209 updated 01/31/22, 00:38

Commit message

The testing-framework got a change to declare
_call() of getAccessibleMock() and
getAccessibleMockForAbstractClass() has a
variadic number of additional arguments.

This makes phpstan and IDE's more happy.

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 01/31/22, 00:26

  2. core-ci voted on patch set 1 V +1 01/31/22, 00:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22765

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 01/31/22, 00:38

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 01/31/22, 00:38

  5. Christian Kuhn merged patch set 2 01/31/22, 00:38