73239[TASK] Properly type hint accessible mocks in tests
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 18
- Build/phpstan/phpstan-baseline.neon+0 −100
- typo3/sysext/backend/Tests/Functional/Controller/Page/LocalizationControllerTest.php+3 −4
- typo3/sysext/backend/Tests/Unit/Controller/SwitchUserControllerTest.php+6 −5
- typo3/sysext/backend/Tests/Unit/Routing/UriBuilderTest.php+0 −11
- typo3/sysext/backend/Tests/Unit/View/BackendLayoutViewTest.php+3 −5
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+3 −8
- typo3/sysext/core/Tests/Unit/Resource/Utility/FileExtensionFilterTest.php+3 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+3 −6
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+2 −5
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php+4 −5
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php5+8 −20
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Service/TranslationServiceTest.php+7 −6
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php+3 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+4 −5
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+3 −2
Review log 79
-
Christian Kuhn uploaded patch set 1 01/31/22, 01:12
-
core-ci voted on patch set 1 V -1 01/31/22, 01:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22769
-
Stefan Bürk commented on patch set 1 01/31/22, 01:32
-
Stefan Bürk uploaded patch set 2 01/31/22, 01:53
-
Stefan Bürk commented on patch set 2 01/31/22, 01:56
CollectionValidatorTest.php:56Replyalso '['translateErrorMessage']' missing for mockMethods.CollectionValidatorTest.php:171options and mockMethods in wrong order -
core-ci voted on patch set 2 V +1 01/31/22, 02:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22770
-
Stefan Bürk commented on patch set 2 V +1 CR +1 01/31/22, 02:07
CollectionValidatorTest.php:56ReplyDoneCollectionValidatorTest.php:171ReplyDone -
Benjamin Franzke voted on patch set 2 V +2 CR +2 01/31/22, 08:50
-
Benjamin Franzke merged patch set 3 01/31/22, 08:51
CollectionValidatorTest.php:56