Review main Merged

73239[TASK] Properly type hint accessible mocks in tests

Christian Kuhn CR +2 V +2 Hard +57 −196 updated 01/31/22, 08:51

Commit message

By adding a couple of dedicated type hints here
and there, phpstan and phpstorm understand _call()
and _set() much better.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/31/22, 01:12

  2. core-ci voted on patch set 1 V -1 01/31/22, 01:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22769

  3. Stefan Bürk commented on patch set 1 01/31/22, 01:32

    CollectionValidatorTest.php:56

    Should this not be ``` $this->validator = $this->getAccessibleMock(CollectionValidator::class, [], [[]], '', true); ``` removed getValidator() method had a "[$options]" where $options was an array, so nested array ...
  4. Stefan Bürk uploaded patch set 2 01/31/22, 01:53

  5. Stefan Bürk commented on patch set 2 01/31/22, 01:56

    CollectionValidatorTest.php:56 Reply

    also '['translateErrorMessage']' missing for mockMethods.

    CollectionValidatorTest.php:171

    options and mockMethods in wrong order
  6. core-ci voted on patch set 2 V +1 01/31/22, 02:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22770

  7. Stefan Bürk commented on patch set 2 V +1 CR +1 01/31/22, 02:07

    CollectionValidatorTest.php:56 Reply

    Done

    CollectionValidatorTest.php:171 Reply

    Done
  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/31/22, 08:50

  9. Benjamin Franzke merged patch set 3 01/31/22, 08:51