Review main Merged

73241[TASK] Fix definition availability checks in DI compiler passes

Benjamin Franzke CR +2 V +2 Normal +23 −102 updated 01/31/22, 09:08

Commit message

findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an alternative
$container->hasDefintion may be used to check for definition availability.

Also adapt the corresponding dashboard test.

Executed commands:

  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Benjamin Franzke uploaded patch set 1 01/31/22, 07:31

  2. core-ci voted on patch set 1 V -1 01/31/22, 07:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22775

  3. Benjamin Franzke uploaded patch set 2 01/31/22, 08:00

  4. core-ci voted on patch set 2 V -1 01/31/22, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22777

  5. Benjamin Franzke uploaded patch set 3 01/31/22, 08:25

  6. core-ci voted on patch set 3 V +1 01/31/22, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22779

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 01/31/22, 08:41

  8. Benni Mack voted on patch set 3 V +1 CR +1 01/31/22, 09:05

  9. Benjamin Franzke voted on patch set 3 V +2 CR +2 01/31/22, 09:08

  10. Benjamin Franzke merged patch set 4 01/31/22, 09:08