Review 11.5 Merged

73243[TASK] Properly type hint accessible mocks in tests

Benjamin Franzke CR +2 V +2 Hard +111 −153 updated 01/31/22, 09:16

Commit message

By adding a couple of dedicated type hints here
and there, phpstan and phpstorm understand _call()
and _set() much better.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 810

  1. Benjamin Franzke uploaded patch set 1 01/31/22, 08:51

  2. core-ci voted on patch set 1 V -1 01/31/22, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22781

  3. Stefan Bürk commented on patch set 1 CR -1 01/31/22, 08:56

    LocalDriverTest.php:101

    return type should be removed, union return types is 8.0 or 8.1 feature
  4. Benjamin Franzke uploaded patch set 2 01/31/22, 08:57

  5. Benjamin Franzke commented on patch set 2 01/31/22, 08:58

    LocalDriverTest.php:101 Reply

    Ack
  6. Stefan Bürk commented on patch set 2 01/31/22, 08:58

    LocalDriverTest.php:101 Reply

    Done
  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/31/22, 09:05

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 01/31/22, 09:06

  9. core-ci voted on patch set 2 V +1 01/31/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22782

  10. Benjamin Franzke merged patch set 3 01/31/22, 09:16