Review 11.5 Merged

73244[TASK] Fix definition availability checks in DI compiler passes

Benjamin Franzke CR +2 V +2 Normal +23 −102 updated 01/31/22, 09:29

Commit message

findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an alternative
$container->hasDefintion may be used to check for definition availability.

Also adapt the corresponding dashboard test.

Executed commands:

  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 23

  1. Benjamin Franzke uploaded patch set 1 01/31/22, 09:16

  2. core-ci voted on patch set 1 V +1 01/31/22, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22783

  3. Benjamin Franzke merged patch set 2 01/31/22, 09:29