Review main Merged

73246[TASK] Fix PHPStan errors in JavaScript module classes

Benjamin Franzke CR +2 V +2 Easy +3 −18 updated 01/31/22, 10:58

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Benjamin Franzke uploaded patch set 1 01/31/22, 10:36

  2. Christian Kuhn commented on patch set 1 V +1 CR +1 01/31/22, 10:41

    ImportMap.php:223

    nice catch.
  3. core-ci voted on patch set 1 V +1 01/31/22, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22787

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 01/31/22, 10:51

  5. Stefan Bürk voted on patch set 1 CR +1 01/31/22, 10:57

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/31/22, 10:58

  7. Benjamin Franzke merged patch set 2 01/31/22, 10:58