Review 11.5 Merged

73249[TASK] Remove broken test from ServiceProviderCompilationPassTest

Benjamin Franzke CR +2 V +2 Easy +0 −38 updated 01/31/22, 12:31

Commit message

PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not contain a proper test
setup, which went undetected as the expected TypeError
was thrown for the invalid test setup.

This could have been fixed but the test actually only
tried to assert whether a callable type declaration is set,
in order to test whether a PHP error is thrown when an
invalid factory is provided. This is useless as such
factory will result in an error once called anyway.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 47

  1. Benjamin Franzke uploaded patch set 1 01/31/22, 12:08

  2. Benjamin Franzke uploaded patch set 2 01/31/22, 12:09

  3. core-ci voted on patch set 1 V -1 01/31/22, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22797

  4. Benjamin Franzke uploaded patch set 3 01/31/22, 12:15

  5. core-ci voted on patch set 2 V -1 01/31/22, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22798

  6. core-ci voted on patch set 3 V +1 01/31/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22799

  7. Benjamin Franzke merged patch set 4 01/31/22, 12:31