Review main Merged

73251[TASK] Serialize PageRenderer state instead of the entire class

Benjamin Franzke CR +2 V +2 Normal +203 −28 updated 02/07/22, 09:54

Commit message

As prepared in #91316, PageRenderer state is now
serialized instead of serializing the entire object,
this means that caches of the importmap are
excluded from serialization.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 2227

Show 12 earlier messages
  1. Benjamin Franzke uploaded patch set 1 01/31/22, 13:38

  2. core-ci voted on patch set 1 V -1 01/31/22, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22803

  1. Benjamin Franzke uploaded patch set 2 01/31/22, 13:56

  2. core-ci voted on patch set 2 V +1 01/31/22, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22806

  3. Christian Kuhn commented on patch set 2 01/31/22, 15:18

    TypoScriptFrontendController.php:2529

    didn't fully understand impact, so maybe stupid question: is it possible to restrict with allowed_classes here as well?
  4. Benjamin Franzke commented on patch set 2 CR -1 02/01/22, 09:09

    TypoScriptFrontendController.php:2529 Reply

    Currently not because of MetaTagManagerRegistry ugliness. will take a further look..
  5. Benjamin Franzke uploaded patch set 3 02/01/22, 13:17

  6. core-ci voted on patch set 3 V -1 02/01/22, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22874

  7. Benjamin Franzke uploaded patch set 4 02/01/22, 13:53

  8. core-ci voted on patch set 4 V +1 02/01/22, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22876

  9. Benjamin Franzke commented on patch set 4 02/01/22, 15:42

    TypoScriptFrontendController.php:2529 Reply

    Done
  10. Benni Mack commented on patch set 4 02/01/22, 16:25

    AbstractMetaTagManager.php:309

    please make these methods internal :) same for the other files.
  11. Benjamin Franzke commented on patch set 4 02/01/22, 17:41

    AbstractMetaTagManager.php:309 Reply

    I had to define these methods on the MetaTagManagerInterface – that's a stateful interface by design – so these methods are kinda API in this case (as that interface is not marked internal). I know interface additions would usually require a Breaking.rst, but I hoped I could get away with the fact that the meta tag managers a provided by core anyway and the implementions are suggested to use the AbstractMetaTagManager which hides the breakage to anyone who implements an own manager.
  12. Benni Mack commented on patch set 4 V +1 CR +1 02/01/22, 21:04

    AbstractMetaTagManager.php:309 Reply

    you're right. thanks for the explanation
  13. Christian Kuhn voted on patch set 4 V +1 CR +1 02/03/22, 15:01

  14. Stefan Bürk voted on patch set 4 CR +1 02/03/22, 17:16

  15. Stefan Bürk voted on patch set 4 V +1 02/03/22, 17:53

  16. Benjamin Franzke commented on patch set 4 CR -1 02/03/22, 19:50

    JavaScriptItems.php:98

    This returns instanced of JavaScriptModuleInstruction which will not pass through unserialization with allowed_class = false. Will fix and add tests. (Note: not a likely case right now, as frontend doesn't use JavaScriptModules yet, but better fix it now than never)
  17. Benjamin Franzke uploaded patch set 5 02/03/22, 19:56

  18. Benjamin Franzke commented on patch set 5 02/03/22, 19:56

    JavaScriptItems.php:98 Reply

    Done
  19. core-ci voted on patch set 5 V +1 02/03/22, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22971

  20. Christian Kuhn voted on patch set 5 V +1 CR +1 02/04/22, 21:51

  21. Benni Mack voted on patch set 5 V +1 CR +1 02/05/22, 22:04

  22. Stefan Bürk voted on patch set 5 V +1 CR +1 02/06/22, 20:12

  23. Benni Mack voted on patch set 5 V +2 CR +2 02/07/22, 09:40

  24. Benni Mack merged patch set 6 02/07/22, 09:40

  25. Oliver Hader voted on patch set 6 CR +1 02/07/22, 09:54