73251[TASK] Serialize PageRenderer state instead of the entire class
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 12
- typo3/sysext/core/Classes/MetaTag/AbstractMetaTagManager.php3+12 −0
- typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php+12 −0
- typo3/sysext/core/Classes/MetaTag/MetaTagManagerInterface.php+4 −0
- typo3/sysext/core/Classes/MetaTag/MetaTagManagerRegistry.php+15 −10
- typo3/sysext/core/Classes/Page/ImportMap.php+18 −0
- typo3/sysext/core/Classes/Page/JavaScriptItems.php2+26 −0
- typo3/sysext/core/Classes/Page/JavaScriptModuleInstruction.php+22 −1
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+42 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php+9 −3
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+33 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+6 −8
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+4 −6
Review log 2227
Show 12 earlier messages
-
Benjamin Franzke uploaded patch set 1 01/31/22, 13:38
-
core-ci voted on patch set 1 V -1 01/31/22, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22803
-
Benjamin Franzke uploaded patch set 2 01/31/22, 13:56
-
core-ci voted on patch set 2 V +1 01/31/22, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22806
-
Christian Kuhn commented on patch set 2 01/31/22, 15:18
-
Benjamin Franzke commented on patch set 2 CR -1 02/01/22, 09:09
TypoScriptFrontendController.php:2529ReplyCurrently not because of MetaTagManagerRegistry ugliness. will take a further look.. -
Benjamin Franzke uploaded patch set 3 02/01/22, 13:17
-
core-ci voted on patch set 3 V -1 02/01/22, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22874
-
Benjamin Franzke uploaded patch set 4 02/01/22, 13:53
-
core-ci voted on patch set 4 V +1 02/01/22, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22876
-
Benjamin Franzke commented on patch set 4 02/01/22, 15:42
TypoScriptFrontendController.php:2529ReplyDone -
Benni Mack commented on patch set 4 02/01/22, 16:25
AbstractMetaTagManager.php:309please make these methods internal :) same for the other files. -
Benjamin Franzke commented on patch set 4 02/01/22, 17:41
AbstractMetaTagManager.php:309ReplyI had to define these methods on the MetaTagManagerInterface – that's a stateful interface by design – so these methods are kinda API in this case (as that interface is not marked internal). I know interface additions would usually require a Breaking.rst, but I hoped I could get away with the fact that the meta tag managers a provided by core anyway and the implementions are suggested to use the AbstractMetaTagManager which hides the breakage to anyone who implements an own manager. -
Benni Mack commented on patch set 4 V +1 CR +1 02/01/22, 21:04
AbstractMetaTagManager.php:309Replyyou're right. thanks for the explanation -
Christian Kuhn voted on patch set 4 V +1 CR +1 02/03/22, 15:01
-
Stefan Bürk voted on patch set 4 CR +1 02/03/22, 17:16
-
Stefan Bürk voted on patch set 4 V +1 02/03/22, 17:53
-
Benjamin Franzke commented on patch set 4 CR -1 02/03/22, 19:50
JavaScriptItems.php:98This returns instanced of JavaScriptModuleInstruction which will not pass through unserialization with allowed_class = false. Will fix and add tests. (Note: not a likely case right now, as frontend doesn't use JavaScriptModules yet, but better fix it now than never) -
Benjamin Franzke uploaded patch set 5 02/03/22, 19:56
-
Benjamin Franzke commented on patch set 5 02/03/22, 19:56
JavaScriptItems.php:98ReplyDone -
core-ci voted on patch set 5 V +1 02/03/22, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22971
-
Christian Kuhn voted on patch set 5 V +1 CR +1 02/04/22, 21:51
-
Benni Mack voted on patch set 5 V +1 CR +1 02/05/22, 22:04
-
Stefan Bürk voted on patch set 5 V +1 CR +1 02/06/22, 20:12
-
Benni Mack voted on patch set 5 V +2 CR +2 02/07/22, 09:40
-
Benni Mack merged patch set 6 02/07/22, 09:40
-
Oliver Hader voted on patch set 6 CR +1 02/07/22, 09:54
TypoScriptFrontendController.php:2529