Review main Merged

73253[TASK] Have variadic typehints in ExpressionBuilder

Stefan Bürk CR +2 V +2 Normal +3 −112 updated 02/05/22, 12:04

Commit message

The patch adds proper typehints for 'andX()' and 'orX()'
of core 'ExpressionBuilder()' facade implementation.
This eliminates the need to have ignore rules for static
code analizers like phpstan.

Some consumers still pass invalid types to these methods,
these can be fixed with further patches and pave the way
towards additional PHP 8.1 based method signature work.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1724

  1. Stefan Bürk uploaded patch set 1 01/31/22, 22:47

  2. core-ci voted on patch set 1 V +1 01/31/22, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22834

  3. Stefan Bürk uploaded patch set 2 02/01/22, 02:12

  4. core-ci voted on patch set 2 V -1 02/01/22, 02:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22854

  5. Stefan Bürk uploaded patch set 3 02/01/22, 02:24

  6. core-ci voted on patch set 3 V +1 02/01/22, 02:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22855

  7. Stefan Bürk updated the commit message in patch set 4 02/01/22, 02:37

  8. core-ci voted on patch set 4 V +1 02/01/22, 02:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22856

  9. Oliver Klee voted on patch set 4 CR +1 02/01/22, 12:06

  10. Benni Mack commented on patch set 4 02/02/22, 10:52

    Not a fan of modifying this for v11.5 again, as we had a regression in TYPO3 v11.5 about this, and I'd really like to avoid another "regression" because of typehintings.
  11. Stefan Bürk updated the commit message in patch set 5 02/02/22, 11:46

  12. Stefan Bürk commented on patch set 5 02/02/22, 11:52

    Reply

    Ack. My argument for "why 11.5" would fall, as we have to talk than with v10 - and that backport would not do at all, so my point got smoked. Removed 11.5 from releases.
  13. Oliver Klee voted on patch set 5 CR +1 02/02/22, 11:56

  14. core-ci voted on patch set 5 V +1 02/02/22, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22901

  15. Christian Kuhn uploaded patch set 6 02/05/22, 06:44

  16. Christian Kuhn voted on patch set 6 V +1 CR +1 02/05/22, 06:45

  17. core-ci voted on patch set 6 V +1 02/05/22, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23033

  18. Christian Kuhn uploaded patch set 7 02/05/22, 11:41

  19. Christian Kuhn voted on patch set 7 V +1 CR +1 02/05/22, 11:41

  20. Susi Moog voted on patch set 7 V +1 CR +1 02/05/22, 11:41

  21. Oliver Klee voted on patch set 7 CR +1 02/05/22, 11:42

  22. core-ci voted on patch set 7 V +1 02/05/22, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23058

  23. Christian Kuhn voted on patch set 7 V +2 CR +2 02/05/22, 12:03

  24. Christian Kuhn merged patch set 8 02/05/22, 12:04