73255[TASK] Remove superfluous elseif condition check in TcaPreparation
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1622
-
Stefan Bürk uploaded patch set 1 01/31/22, 23:56
-
core-ci voted on patch set 1 V +1 02/01/22, 00:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22839
-
Christian Kuhn updated the commit message in patch set 2 02/01/22, 00:54
-
Christian Kuhn voted on patch set 2 V +1 CR +1 02/01/22, 00:56
-
Christian Kuhn commented on patch set 2 02/01/22, 00:58
let's have a second vote from oli on this one if possible. -
core-ci voted on patch set 2 V +1 02/01/22, 01:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22846
-
Benni Mack voted on patch set 2 V +1 CR +1 02/01/22, 09:20
-
Oli Bartsch commented on patch set 2 02/01/22, 09:20
TcaPreparation.php:119Shouldn't this then be the elseif ? -
Wouter Wolters commented on patch set 2 02/01/22, 11:51
phpstan -
Stefan Bürk commented on patch set 2 CR -1 02/01/22, 12:09
on itReply
Thanks, will fix it with the next push. Insider: noted same typo3 on another patch recently ;)TcaPreparation.php:119ReplyYeah, ack .. and thanks for your comment Oliver, that made me rethink about that all. I have eventually an idea to solve the phpstan issue here in another way, but keep it obious to humans which is checked, and also eleminating this nested if/else. Will push shortly. -
Stefan Bürk uploaded patch set 3 02/01/22, 13:14
-
Stefan Bürk commented on patch set 3 02/01/22, 13:19
Reply
DoneTcaPreparation.php:119ReplyHopefully my new solution makes more sense at all and satisfies your rightfull comment, Oliver. -
core-ci voted on patch set 3 V +1 02/01/22, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22873
-
Stefan Bürk uploaded patch set 4 02/01/22, 15:39
-
Stefan Bürk uploaded patch set 5 02/01/22, 15:40
-
core-ci voted on patch set 4 V +1 02/01/22, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22878
-
core-ci voted on patch set 5 V +1 02/01/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22879
-
Oli Bartsch updated the commit message in patch set 6 02/01/22, 16:35
-
Oli Bartsch voted on patch set 6 V +1 CR +1 02/01/22, 16:35
-
core-ci voted on patch set 6 V +1 02/01/22, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22882
-
Christian Kuhn voted on patch set 6 V +2 CR +2 02/05/22, 08:16
-
Christian Kuhn merged patch set 7 02/05/22, 08:16