73259[TASK] Use generics for ObjectProphecy class properties
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 40
- typo3/sysext/adminpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php+3 −0
- typo3/sysext/adminpanel/Tests/Unit/Service/ConfigurationServiceTest.php+1 −0
- typo3/sysext/backend/Tests/Unit/Configuration/BackendUserConfigurationTest.php+1 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php+1 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php+1 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexProcessTest.php+1 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineTest.php+1 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataCompilerTest.php+1 −0
- typo3/sysext/backend/Tests/Unit/Security/EmailLoginNotificationTest.php+3 −0
- typo3/sysext/backend/Tests/UnitDeprecated/Form/FormDataProvider/TcaFlexPrepareTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Console/CommandRegistryTest.php+1 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+3 −0
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/EventListener/SchemaColumnDefinitionListenerTest.php+8 −7
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderRegistryTest.php+1 −0
- typo3/sysext/core/Tests/Unit/EventDispatcher/EventDispatcherTest.php+2 −0
- typo3/sysext/core/Tests/Unit/EventDispatcher/ListenerProviderTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconFactoryTest.php+1 −0
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+1 −0
- typo3/sysext/core/Tests/Unit/Routing/Aspect/AspectFactoryTest.php+2 −0
Show 20 more files
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php+1 −0
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+1 −0
- typo3/sysext/dashboard/Tests/Unit/DependencyInjection/DashboardWidgetPassTest.php+2 −0
- typo3/sysext/dashboard/Tests/Unit/WidgetRegistryTest.php+2 −0
- typo3/sysext/extbase/Tests/Functional/Service/ExtensionServiceTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+6 −0
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Utility/LocalizationUtilityTest.php+2 −0
- typo3/sysext/felogin/Tests/Unit/Configuration/RecoveryConfigurationTest.php+4 −0
- typo3/sysext/felogin/Tests/Unit/Redirect/RedirectHandlerTest.php+3 −0
- typo3/sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php+4 −0
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+1 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentDataProcessorTest.php+1 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+1 −0
- typo3/sysext/frontend/Tests/Unit/DataProcessing/FlexFormProcessorTest.php+1 −0
- typo3/sysext/frontend/Tests/UnitDeprecated/ContentObject/ContentObjectRendererTest.php+1 −0
- typo3/sysext/install/Tests/Unit/UpgradeAnalysis/DocumentationFileTest.php+1 −0
- typo3/sysext/opendocs/Tests/Unit/Service/OpenDocumentServiceTest.php+1 −0
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+4 −0
Review log 78
-
Benjamin Franzke uploaded patch set 1 02/01/22, 15:55
-
core-ci voted on patch set 1 V +1 02/01/22, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22880
-
Stefan Bürk commented on patch set 1 V +1 CR +1 02/01/22, 16:43
Took a while, getting your point on the related patch. But now with this patch and testing, this makes absolutly sense. Sure, it won't help in IDE (PHPStorm), which is a pitty, but phpstan can it's job better. Thanks for your nailing and providing this patch, Benjamin !! -
Stefan Bürk commented on patch set 1 02/01/22, 16:51
Reply
can do* -
Benni Mack voted on patch set 1 V +1 CR +1 02/02/22, 10:45
-
Oliver Klee voted on patch set 1 CR +1 02/02/22, 11:32
-
Benjamin Franzke voted on patch set 1 V +2 CR +2 02/03/22, 08:04
-
Benjamin Franzke merged patch set 2 02/03/22, 08:07