73261[TASK] Streamline getLanguageService function
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 145
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractModule.php+0 −5
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractSubModule.php+0 −5
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+0 −3
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+0 −5
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+0 −3
- typo3/sysext/backend/Classes/Controller/Wizard/AbstractWizardController.php+1 −6
- typo3/sysext/backend/Classes/Controller/AbstractFormEngineAjaxController.php+0 −3
- typo3/sysext/backend/Classes/Controller/ContextMenuController.php+0 −5
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+1 −4
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+0 −5
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+1 −6
- typo3/sysext/backend/Classes/Domain/Repository/TableManualRepository.php+2 −6
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/FullRecordContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/ListOfFieldsContainer.php+1 −4
Show 125 more files
- typo3/sysext/backend/Classes/Form/Container/OuterWrapContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/TabsContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+1 −4
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+0 −9
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+0 −9
- typo3/sysext/backend/Classes/Form/Element/InputDateTimeElement.php+0 −9
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+0 −9
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+0 −9
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+0 −9
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+0 −9
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+0 −9
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+0 −9
- typo3/sysext/backend/Classes/Form/FieldControl/InsertClipboard.php+0 −3
- typo3/sysext/backend/Classes/Form/FieldInformation/AdminIsSystemMaintainer.php+0 −3
- typo3/sysext/backend/Classes/Form/FieldInformation/TcaDescription.php+0 −5
- typo3/sysext/backend/Classes/Form/FieldWizard/DefaultLanguageDifferences.php+1 −4
- typo3/sysext/backend/Classes/Form/FieldWizard/LocalizationStateSelector.php+1 −4
- typo3/sysext/backend/Classes/Form/FieldWizard/RecordsOverview.php+1 −4
- typo3/sysext/backend/Classes/Form/FieldWizard/TableList.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseSystemLanguageRows.php+0 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessFieldDescriptions.php+0 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessFieldLabels.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRadioItems.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+1 −4
- typo3/sysext/backend/Classes/Form/NodeExpansion/FieldControl.php+1 −4
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+1 −4
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+2 −6
- typo3/sysext/backend/Classes/Module/ModuleLoader.php+1 −4
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+0 −3
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+1 −6
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+1 −4
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+1 −6
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −4
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+1 −4
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −5
- typo3/sysext/backend/Tests/Unit/Module/ModuleLoaderTest.php4+7 −1
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php2+4 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+1 −4
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −4
- typo3/sysext/core/Classes/DataHandling/ItemProcessingService.php+1 −4
- typo3/sysext/core/Classes/Hooks/BackendUserGroupIntegrityCheck.php+1 −4
- typo3/sysext/core/Classes/Service/IsoCodeService.php+3 −6
- typo3/sysext/core/Classes/Site/Entity/NullSite.php+0 −4
- typo3/sysext/core/Classes/Site/Entity/Site.php+0 −4
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+0 −3
- typo3/sysext/core/Classes/TypoScript/Parser/ConstantConfigurationParser.php+0 −3
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+1 −4
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+1 −6
- typo3/sysext/dashboard/Classes/Dashboard.php+0 −3
- typo3/sysext/dashboard/Classes/DashboardPreset.php+0 −3
- typo3/sysext/dashboard/Classes/WidgetGroup.php+0 −3
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php+0 −3
- typo3/sysext/extensionmanager/Classes/Controller/ExtensionComposerStatusController.php+2 −1
- typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php+1 −4
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+0 −5
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.php+0 −3
- typo3/sysext/filelist/Classes/Controller/File/RenameFileController.php+0 −3
- typo3/sysext/filelist/Classes/Controller/File/ReplaceFileController.php+0 −3
- typo3/sysext/filelist/Classes/Controller/FileListController.php+0 −5
- typo3/sysext/filelist/Classes/FileList.php+1 −6
- typo3/sysext/form/Classes/Controller/FormEditorController.php+0 −5
- typo3/sysext/form/Classes/Controller/FormManagerController.php+0 −5
- typo3/sysext/form/Classes/Hooks/DataStructureIdentifierHook.php+0 −3
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+0 −3
- typo3/sysext/form/Classes/Service/TranslationService.php+0 −3
- typo3/sysext/impexp/Classes/ImportExport.php+0 −3
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+1 −4
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+0 −3
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+0 −3
- typo3/sysext/info/Classes/Controller/PageInformationController.php+0 −3
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+0 −3
- typo3/sysext/install/Classes/Report/EnvironmentStatusReport.php+0 −3
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+1 −4
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+0 −3
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+0 −3
- typo3/sysext/linkvalidator/Classes/Linktype/AbstractLinktype.php+1 −4
- typo3/sysext/linkvalidator/Classes/Result/LinkAnalyzerResult.php+0 −3
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php+0 −3
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+1 −4
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+1 −4
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+1 −4
- typo3/sysext/recordlist/Classes/Controller/ClearPageCacheController.php+0 −5
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php+1 −4
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+0 −3
- typo3/sysext/recordlist/Classes/LinkHandler/AbstractLinkHandler.php+1 −4
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −5
- typo3/sysext/recycler/Classes/Domain/Model/Tables.php+2 −6
- typo3/sysext/recycler/Classes/Task/CleanerFieldProvider.php+2 −4
- typo3/sysext/recycler/Classes/Utility/RecyclerUtility.php+2 −6
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+1 −4
- typo3/sysext/reports/Classes/Report/Status/FalStatus.php+1 −4
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+0 −3
- typo3/sysext/reports/Classes/Report/Status/Status.php+1 −4
- typo3/sysext/reports/Classes/Report/Status/SystemStatus.php+1 −4
- typo3/sysext/reports/Classes/Report/Status/Typo3Status.php+1 −4
- typo3/sysext/reports/Classes/Report/Status/WarningMessagePostProcessor.php+1 −4
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTaskNotificationEmailField.php+1 −4
- typo3/sysext/scheduler/Classes/Example/SleepTaskAdditionalFieldProvider.php+0 −3
- typo3/sysext/scheduler/Classes/Example/TestTaskAdditionalFieldProvider.php+0 −3
- typo3/sysext/scheduler/Classes/SystemInformation/ToolbarItemProvider.php+0 −3
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+0 −3
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionAdditionalFieldProvider.php+0 −3
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php+0 −3
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+2 −4
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationAdditionalFieldProvider.php+0 −5
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+0 −3
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionAdditionalFieldProvider.php+0 −3
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php+0 −3
- typo3/sysext/t3editor/Classes/Controller/CodeCompletionController.php+0 −3
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php+0 −3
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+0 −3
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+0 −4
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+0 −3
- typo3/sysext/workspaces/Classes/Controller/Remote/MassActionHandler.php+1 −4
- typo3/sysext/workspaces/Classes/Domain/Record/AbstractRecord.php+2 −4
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php+0 −3
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+0 −3
- typo3/sysext/workspaces/Classes/Service/HistoryService.php+1 −4
- typo3/sysext/workspaces/Classes/Service/StagesService.php+0 −3
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+0 −3
Review log 1113
-
Torben Hansen uploaded patch set 1 02/02/22, 14:55
-
core-ci voted on patch set 1 V +1 02/02/22, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22908
-
Oliver Klee voted on patch set 1 CR +1 02/02/22, 15:13
-
Stefan Bürk commented on patch set 1 CR -1 02/02/22, 15:43
Thanks for the patch. I have two minor comments which should be adjusted. A lot of work so really thanks. At some places removing docblcok from getBackendUser() related methods would have been nice, but don't take that as a blocker.ModuleLoaderTest.php:36Please use ``` /** @var ObjectPropecy<LanguageService> $languageServicePhrophet = ... ``` We had a patch removing them, and Benjamin had to create a follow up patch to put them back in a proper way. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73259BackendUtilityTest.php:159same here (var docblock). https://review.typo3.org/c/Packages/TYPO3.CMS/+/73259 -
Stefan Bürk commented on patch set 1 02/02/22, 15:44
ModuleLoaderTest.php:36Reply$languageServicePhropecy .. sry ;) -
Torben Hansen commented on patch set 1 02/02/22, 18:04
Reply
I will create a separate patch for the similar changes to getBackendUser()ModuleLoaderTest.php:36ReplyI now renamed $languageService to $languageServiceProphecy to be more specific that we have a prophecy here. But: The referred patch does only bring back the annotations for class properties or function results. For local usage of prophecies in functions this does not seem to be required. Do you agree? -
Torben Hansen uploaded patch set 2 02/02/22, 18:05
-
core-ci voted on patch set 2 V +1 02/02/22, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22913
-
Oliver Klee voted on patch set 2 CR +1 02/02/22, 18:15
-
Stefan Bürk commented on patch set 2 V +1 CR +1 02/02/22, 18:21
ModuleLoaderTest.php:36ReplyThanks Torben, and you are absoluty right. So let it be the same here, but thanks for revisiting and at least renaming the variable name. Maybe we should "check" if this should be done for these kinds to, will ping Benjamin about this. Maybe we will do a dedicated patch than - or not. -
Stefan Bürk commented on patch set 2 02/02/22, 18:21
BackendUtilityTest.php:159ReplyDone -
Benni Mack commented on patch set 2 V +2 CR +2 02/02/22, 18:49
Thank you! -
Benni Mack merged patch set 3 02/02/22, 18:49