Review main Merged

73262[BUGFIX] Fix PHPStan warnings in StagesService

Oliver Klee CR +2 V +2 Easy +7 −18 updated 02/04/22, 14:42

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1216

  1. Oliver Klee uploaded patch set 1 02/02/22, 22:34

  2. Oliver Klee updated the commit message in patch set 2 02/02/22, 22:35

  3. core-ci voted on patch set 2 V +1 02/02/22, 22:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22927

  4. core-ci voted on patch set 1 V +1 02/02/22, 22:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22926

  5. Andreas Kienast voted on patch set 2 CR +1 02/03/22, 12:27

  6. Stefan Bürk commented on patch set 2 02/03/22, 12:54

    StagesService.php:320

    We should avoid this style here to make it instantly visible that this is a nested array. Nitpicking, but would you be fine with this ? ``` $nestStage = [ [ // ... ], ]; ```
  7. Oliver Klee commented on patch set 2 02/03/22, 13:56

    StagesService.php:320 Reply

    Thanks, of course! I'll update and repush in a second.
  8. Oliver Klee uploaded patch set 3 02/03/22, 13:57

  9. Oliver Klee commented on patch set 3 02/03/22, 13:57

    StagesService.php:320 Reply

    Done
  10. core-ci voted on patch set 3 V -1 02/03/22, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22949

  11. Oliver Klee uploaded patch set 4 02/03/22, 14:18

  12. core-ci voted on patch set 4 V +1 02/03/22, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22952

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 02/03/22, 15:39

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 02/03/22, 17:15

  15. Benni Mack voted on patch set 4 V +2 CR +2 02/04/22, 14:42

  16. Benni Mack merged patch set 5 02/04/22, 14:42