Review main Merged

73264[BUGFIX] Fix undefined key warnings in language handling of extbase

Georg Ringer CR +2 V +2 Easy +2 −7 updated 02/04/22, 07:20

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1417

  1. Georg Ringer uploaded patch set 1 02/03/22, 08:47

  2. Georg Ringer commented on patch set 1 02/03/22, 08:47

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 02/03/22, 08:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22935

  4. Georg Ringer uploaded patch set 2 02/03/22, 09:55

  5. core-ci voted on patch set 2 V +1 02/03/22, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22940

  6. Simon Gilli voted on patch set 2 CR +1 02/03/22, 10:25

  7. Christian Kuhn commented on patch set 2 02/03/22, 10:27

    Typo3DbBackend.php:514

    it would be sematically better to "?? false" here. same for the first if part.
  8. Stefan Bürk commented on patch set 2 02/03/22, 11:38

    Typo3DbBackend.php:514 Reply

    Had the same thought, forgot to comment it.
  9. Stefan Bürk uploaded patch set 3 02/03/22, 11:38

  10. Stefan Bürk voted on patch set 3 CR +1 02/03/22, 11:41

  11. Stefan Bürk commented on patch set 3 02/03/22, 11:42

    Typo3DbBackend.php:514 Reply

    Done
  12. core-ci voted on patch set 3 V +1 02/03/22, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22942

  13. Oliver Klee voted on patch set 3 CR +1 02/03/22, 14:00

  14. Stefan Bürk voted on patch set 3 V +1 02/03/22, 15:26

  15. Christian Kuhn voted on patch set 3 V +1 CR +1 02/03/22, 21:27

  16. Georg Ringer voted on patch set 3 V +2 CR +2 02/04/22, 07:20

  17. Georg Ringer merged patch set 4 02/04/22, 07:20