Review main Merged

73266[BUGFIX] Handle non-existing table in MissingRelationsCommand

Stefan Bürk CR +2 V +2 Easy +15 −10 updated 02/05/22, 12:13

Commit message

Checking relations to tables that don't exist in the
database for whatever reason crashes MissingRelationsCommand.

Catch the DBAL 'TableNotFoundException' and handle
it gracefully instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1421

  1. Stefan Bürk uploaded patch set 1 02/03/22, 09:29

  2. core-ci voted on patch set 1 V -1 02/03/22, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22938

  3. Stefan Bürk uploaded patch set 2 02/03/22, 09:33

  4. core-ci voted on patch set 2 V +1 02/03/22, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22939

  5. Stefan Bürk uploaded patch set 3 02/03/22, 12:19

  6. core-ci voted on patch set 3 V +1 02/03/22, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22943

  7. Stefan Bürk commented on patch set 3 CR -1 02/03/22, 12:38

    currently testing with v9 backport on a instance (copy) we have this issue. Takes some time, so stay tuned.
  8. Stefan Bürk updated the commit message in patch set 4 02/03/22, 17:18

  9. Stefan Bürk commented on patch set 4 02/03/22, 17:20

    Reply

    This working. Still have a ton of other issues, bubbling up in our instance when executing this command. But they are deeper in the system (datahandler -> hook -> etc) so will investigate them dedicated from this and will came up with dedicated patches for the follow up / other issues.
  10. core-ci voted on patch set 4 V +1 02/03/22, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22963

  11. Christian Kuhn uploaded patch set 5 02/05/22, 06:34

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 02/05/22, 06:35

  13. core-ci voted on patch set 5 V +1 02/05/22, 06:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23032

  14. Christian Kuhn updated the commit message in patch set 6 02/05/22, 11:43

  15. Christian Kuhn voted on patch set 6 V +1 CR +1 02/05/22, 11:43

  16. Susi Moog voted on patch set 6 V +1 CR +1 02/05/22, 11:45

  17. Oliver Klee voted on patch set 6 CR +1 02/05/22, 11:50

  18. core-ci voted on patch set 6 V -1 02/05/22, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23059

  19. core-ci voted on patch set 6 V +1 02/05/22, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23059

  20. Christian Kuhn voted on patch set 6 V +2 CR +2 02/05/22, 12:13

  21. Christian Kuhn merged patch set 7 02/05/22, 12:13