Review main Merged

73293[TASK] Update to phpstan/phpstan:^1.4.5

Christian Kuhn CR +2 V +2 Hard +65 −535 updated 02/04/22, 16:06

Commit message

This brings a couple of fixes for false positives
that shrink the baseline by around 90 errors.

> composer req --dev phpstan/phpstan:^1.4.5
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Christian Kuhn uploaded patch set 1 02/04/22, 15:06

  2. Christian Kuhn uploaded patch set 2 02/04/22, 15:08

  3. core-ci voted on patch set 2 V +1 02/04/22, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23001

  4. core-ci voted on patch set 1 V +1 02/04/22, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23000

  5. Oliver Klee voted on patch set 2 V +1 CR +1 02/04/22, 15:32

  6. Benni Mack voted on patch set 2 V +1 CR +1 02/04/22, 15:39

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 02/04/22, 16:06

  8. Christian Kuhn merged patch set 3 02/04/22, 16:06