Review 11.5 Merged

73299[TASK] Remove superfluous elseif condition check in TcaPreparation

Christian Kuhn CR +2 V +2 Easy +8 −18 updated 02/05/22, 08:57

Commit message

phpstan complained about a superfluous 'elseif()' condition
in 'TcaPreparation::configureCategoryRelations()'.

This patch eliminates the superfluous condition by replacing
the condition with a nested inner condition. This makes phpstan
happy and removes one entry from the phpstan baseline file.

used commands:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/05/22, 08:22

  2. core-ci voted on patch set 1 V +1 02/05/22, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23036

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 02/05/22, 08:57

  4. Christian Kuhn merged patch set 2 02/05/22, 08:57