73304[TASK] Streamline functions returning $GLOBALS['BE_USER']
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 99
- typo3/sysext/adminpanel/Classes/Controller/AjaxController.php+0 −5
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractModule.php+0 −6
- typo3/sysext/adminpanel/Classes/Modules/TsDebug/TypoScriptWaterfall.php+0 −12
- typo3/sysext/adminpanel/Classes/Repositories/FrontendGroupsRepository.php+0 −5
- typo3/sysext/adminpanel/Classes/Service/ConfigurationService.php+0 −6
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+0 −5
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+0 −5
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+0 −3
- typo3/sysext/backend/Classes/Controller/Wizard/AbstractWizardController.php+1 −6
- typo3/sysext/backend/Classes/Controller/Wizard/SuggestWizardController.php+2 −4
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+1 −4
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+2 −4
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+1 −4
- typo3/sysext/backend/Classes/Controller/LogoutController.php+2 −6
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+2 −4
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+0 −5
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+0 −5
- typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php+0 −5
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+0 −3
- typo3/sysext/backend/Classes/Domain/Repository/TableManualRepository.php+0 −5
Show 79 more files
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/OuterWrapContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php+1 −6
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+1 −6
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+1 −4
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+1 −4
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+1 −4
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+1 −4
- typo3/sysext/backend/Classes/Form/FieldInformation/AdminIsSystemMaintainer.php+0 −3
- typo3/sysext/backend/Classes/Form/FieldWizard/RecordsOverview.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseSystemLanguageRows.php+0 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseUserPermissionCheck.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/EvaluateDisplayConditions.php+2 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineExpandCollapseState.php+1 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/UserTsConfig.php+1 −4
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+1 −4
- typo3/sysext/backend/Classes/History/Event/AfterHistoryRollbackFinishedEvent.php+2 −2
- typo3/sysext/backend/Classes/History/Event/BeforeHistoryRollbackStartEvent.php2+2 −2
- typo3/sysext/backend/Classes/History/RecordHistoryRollback.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+2 −6
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+0 −3
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+1 −4
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+1 −6
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −4
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineExpandCollapseStateTest.php+4 −2
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+0 −3
- typo3/sysext/beuser/Classes/Domain/Model/BackendUser.php+0 −3
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+2 −6
- typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php+0 −3
- typo3/sysext/core/Classes/Resource/Service/UserFileMountService.php+0 −5
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+2 −6
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+2 −4
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+0 −3
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+0 −5
- typo3/sysext/filelist/Classes/Controller/FileListController.php+0 −5
- typo3/sysext/filelist/Classes/FileList.php+1 −6
- typo3/sysext/form/Classes/Controller/FormEditorController.php+0 −5
- typo3/sysext/form/Classes/Controller/FormManagerController.php+0 −5
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+0 −3
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/FormDefinitionArrayConverter.php+0 −3
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −0
- typo3/sysext/impexp/Classes/ImportExport.php+0 −3
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+1 −4
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+1 −4
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+0 −3
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+0 −3
- typo3/sysext/info/Classes/Controller/PageInformationController.php+0 −3
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+0 −5
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+0 −3
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+1 −4
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+1 −4
- typo3/sysext/recordlist/Classes/Controller/ClearPageCacheController.php+0 −3
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php+1 −4
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+0 −3
- typo3/sysext/recordlist/Classes/LinkHandler/AbstractLinkHandler.php+1 −4
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −4
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+0 −5
- typo3/sysext/recycler/Classes/Utility/RecyclerUtility.php+2 −6
- typo3/sysext/reports/Classes/Report/Status/WarningMessagePostProcessor.php+1 −4
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php3+0 −9
- typo3/sysext/rte_ckeditor/Classes/Form/Resolver/RichTextNodeResolver.php+1 −4
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −6
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+0 −4
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+0 −3
- typo3/sysext/workspaces/Classes/Controller/Remote/MassActionHandler.php+1 −4
- typo3/sysext/workspaces/Classes/Controller/AjaxController.php+1 −4
- typo3/sysext/workspaces/Classes/Domain/Record/AbstractRecord.php+2 −4
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+0 −3
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+1 −4
- typo3/sysext/workspaces/Classes/Service/StagesService.php+1 −4
Review log 1621
-
Torben Hansen uploaded patch set 1 02/05/22, 11:36
-
Oliver Klee commented on patch set 1 02/05/22, 11:48
Looks very good. I've added one comment.BeforeHistoryRollbackStartEvent.php:56If |null is allowed, we should also make the native type declaration nullable. -
core-ci voted on patch set 1 V -1 02/05/22, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23056
-
Torben Hansen uploaded patch set 2 02/05/22, 12:08
-
Torben Hansen commented on patch set 1 02/05/22, 12:09
BeforeHistoryRollbackStartEvent.php:56ReplyDone. Found 2 additional nullable type declarations of the same type and updated the patch/commit message. -
Oliver Klee voted on patch set 2 CR +1 02/05/22, 12:12
-
core-ci voted on patch set 2 V -1 02/05/22, 12:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23064
-
Torben Hansen uploaded patch set 3 02/05/22, 12:36
-
Oliver Klee voted on patch set 3 CR +1 02/05/22, 12:46
-
core-ci voted on patch set 3 V -1 02/05/22, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23069
-
Christian Kuhn commented on patch set 3 CR -1 02/05/22, 12:54
RichTextElement.php:401this is used in the class. -
Torben Hansen commented on patch set 3 02/05/22, 13:02
RichTextElement.php:401ReplyThis class extends TYPO3\CMS\Backend\Form\Element\AbstractFormElement, where getBackendUser() is declared. So IMO this is a superfluous overwrite of the function or am I missing something? -
Christian Kuhn commented on patch set 3 CR 0 02/05/22, 13:20
RichTextElement.php:401ReplyAck -
Torben Hansen uploaded patch set 4 02/05/22, 14:04
-
core-ci voted on patch set 4 V -1 02/05/22, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23071
-
Oliver Klee commented on patch set 4 02/05/22, 15:16
The build failure seems to be caused by a full file system on the GitLab runner. -
core-ci voted on patch set 4 V +1 02/05/22, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23071
-
Christian Kuhn voted on patch set 4 V +1 CR +1 02/05/22, 19:13
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 02/05/22, 21:37
-
Christian Kuhn voted on patch set 4 V +2 CR +2 02/05/22, 21:43
-
Christian Kuhn merged patch set 5 02/05/22, 21:43