Review 11.5 Merged

73307[BUGFIX] Avoid PHP 8.0/8.1 error in RecordHistory

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 02/05/22, 12:29

Commit message

When passing null as $value parameter, an exception is
thrown as the return value must be of type string. We
avoid this by adding string type-hints to the signature
of two methods and string cast the values directly in
the class constructor.

It should be investigated constructor arguments can be
tightened with another patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 02/05/22, 12:12

  2. Oliver Klee voted on patch set 1 CR +1 02/05/22, 12:14

  3. core-ci voted on patch set 1 V +1 02/05/22, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23066

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 02/05/22, 12:29

  5. Christian Kuhn merged patch set 2 02/05/22, 12:29