Review main Merged

73313[TASK] Use new backend templating in ext:install

Christian Kuhn CR +2 V +2 Normal +69 −98 updated 02/07/22, 08:15

Commit message

The ext:install BackendModuleController which renders
the install tool login modal now bows to the general
backend templating strategy.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 02/06/22, 00:24

  2. core-ci voted on patch set 1 V +1 02/06/22, 00:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23085

  3. Nikita Hovratov uploaded patch set 2 02/06/22, 11:25

  4. Nikita Hovratov voted on patch set 2 V +1 CR +1 02/06/22, 11:26

  5. Nikita Hovratov commented on patch set 2 02/06/22, 11:27

    Changed to $view->renderResponse() because else the view is rendered twice.
  6. core-ci voted on patch set 2 V +1 02/06/22, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23092

  7. Stefan Bürk commented on patch set 2 V +1 CR +1 02/06/22, 13:40

    Reply

    Ack.
  8. Christian Kuhn voted on patch set 2 V +2 CR +2 02/07/22, 08:15

  9. Christian Kuhn merged patch set 3 02/07/22, 08:15